Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DHCP darwin and v0.108.0-b.11 #4836

Closed
3 tasks done
kour1er opened this issue Aug 13, 2022 · 4 comments
Closed
3 tasks done

DHCP darwin and v0.108.0-b.11 #4836

kour1er opened this issue Aug 13, 2022 · 4 comments
Assignees
Milestone

Comments

@kour1er
Copy link

kour1er commented Aug 13, 2022

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to report a bug and not ask a question

Operating system type

macOS (aka Darwin)

CPU architecture

AMD64

Installation

GitHub releases or script from README

Setup

On one machine

AdGuard Home version

v0.108.0-b.11

Description

What did you do?

Upgraded via the built in upgrade mechanism from b.10 to b.11

Expected result

For DHCP to work

Actual result

In b.11, in my environment, DHCP fails. After the lease time expires, clients do not receive new information. If I manually stop and restart DHCP via the Adguard Home web interface, I get this error:

"Error: control/dhcp/set_config | enabling dhcp: starting dhcp server: dhcpv4: creating raw udp connection: listen packet [redacted MAC address] packet: not implemented on darwin | 400"

If I roll back to b.10 DHCP starts working again correctly. Am I missing something obvious?

@EugeneOne1
Copy link
Member

@kour1er, hello and thanks for the report. It's indeed a bug, I suppose it affects all the AGH users with macOS. We'll try to fix it as soon as possible.

@EugeneOne1 EugeneOne1 added this to the v0.107.10 milestone Aug 15, 2022
adguard pushed a commit that referenced this issue Aug 15, 2022
Updates #4836.

Squashed commit of the following:

commit 6fe1721
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Aug 15 17:48:41 2022 +0300

    dhcpd: reverd mod upd
@ainar-g
Copy link
Contributor

ainar-g commented Aug 15, 2022

@kour1er, hello. We've reverted some of the changes that could cause that in f58265ec. This change has now been published to the Edge channel. Could you please see if that fixes the issue for you? If it does, we'll try to release the fix to Beta and Release channels sometime this week.

@kour1er
Copy link
Author

kour1er commented Aug 16, 2022

Wow that was fast 👍
So I've tested with the edge build linked from the main page - it reports version: v0.108.0-a.196+6e63757f

With this build, DHCP is working fine again (this is the mac 64 bit version on Intel). Cheers

@ainar-g
Copy link
Contributor

ainar-g commented Aug 16, 2022

Thanks for checking out!

@ainar-g ainar-g closed this as completed Aug 16, 2022
adguard pushed a commit that referenced this issue Aug 17, 2022
Updates #4836.

Squashed commit of the following:

commit 6fe1721
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Aug 15 17:48:41 2022 +0300

    dhcpd: reverd mod upd
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Updates AdguardTeam#4836.

Squashed commit of the following:

commit 6fe1721
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Aug 15 17:48:41 2022 +0300

    dhcpd: reverd mod upd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants