Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdGuard Home on Edge crashes if statistics were disabled #5627

Closed
3 tasks done
flavorgold1 opened this issue Mar 24, 2023 · 4 comments
Closed
3 tasks done

AdGuard Home on Edge crashes if statistics were disabled #5627

flavorgold1 opened this issue Mar 24, 2023 · 4 comments
Assignees
Milestone

Comments

@flavorgold1
Copy link

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to report a bug and not ask a question

Operating system type

Windows

CPU architecture

AMD64

Installation

GitHub releases or script from README

Setup

On one machine

AdGuard Home version

0.108.0-a.475+bea39934

Description

What did you do?

Start it.

Expected result

Work as normal.

Actual result

2023/03/24 00:33:18.210264 [fatal] init stats: unsupported interval: less than an hour

Screenshots (if applicable)

Additional information

This seems to be happening on ALL platforms.

@liuhaoXD
Copy link

It seem that you are trying to set an invalid value to statistics.interval in config file, statistics is a new config entry introduced in v0.107.24 according to https://github.com/AdguardTeam/AdGuardHome/wiki/Configuration. Full text of your config file will be more helpful for troubleshooting.

@ainar-g
Copy link
Contributor

ainar-g commented Mar 24, 2023

Thanks for the report. Seems like a migration gone wrong. We're fixing it.

EDIT: The workaround, as hinted at by liuhaoXD, is to set the statistics interval to a non-zero value, for example 1.

@ainar-g ainar-g self-assigned this Mar 24, 2023
@ainar-g ainar-g added this to the v0.107.27 milestone Mar 24, 2023
@ainar-g ainar-g pinned this issue Mar 24, 2023
@ainar-g ainar-g changed the title AdGuard Home, version v0.108.0-a.475+bea39934 [latest edge] crashes immediately AdGuard Home on Edge crashes if statistics were disabled Mar 24, 2023
@flavorgold1
Copy link
Author

I changed that interval to 2160h.

@ainar-g
Copy link
Contributor

ainar-g commented Mar 24, 2023

This should be fixed as of latest Edge builds. Once again, thanks for reporting.

@ainar-g ainar-g closed this as completed Mar 24, 2023
adguard pushed a commit that referenced this issue Mar 24, 2023
Updates #5627.

Squashed commit of the following:

commit 018ead11959efeaace5312b5990ad82b6fa1f72d
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri Mar 24 12:48:25 2023 +0300

    home: fix more

commit 4bc57a07412bfb7fb7e6c88c14037c567c94d373
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri Mar 24 12:32:57 2023 +0300

    home: fix statistics migration
@ainar-g ainar-g unpinned this issue Mar 24, 2023
@ainar-g ainar-g modified the milestones: v0.107.29, v0.107.28 Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants