Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGH v0.107.28 docker image does not start #5713

Closed
3 tasks done
szjani opened this issue Apr 12, 2023 · 18 comments
Closed
3 tasks done

AGH v0.107.28 docker image does not start #5713

szjani opened this issue Apr 12, 2023 · 18 comments
Labels
docker Docker-related issues

Comments

@szjani
Copy link

szjani commented Apr 12, 2023

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to report a bug and not ask a question

Operating system type

Linux, Other (please mention the version in the description)

CPU architecture

AMD64

Installation

Docker

Setup

On one machine

AdGuard Home version

v0.107.28

Description

What did you do?

I was using v0.107.27 in Docker on a Synology NAS. Watchtower updated the container to v0.107.28 and the container is continuously restarted as it cannot not start. I had a lot of successful version updates with Watchtower, this is the first time it fails.

Expected result

Minor version upgrade should happen without any issues.

Actual result

The container does not start. I can see the followings in the log:

[FATAL tini (7)] exec -h failed: No such file or directory
[FATAL tini (11)] exec -h failed: No such file or directory
[FATAL tini (8)] exec -h failed: No such file or directory

Screenshots (if applicable)

image

Additional information

Moving back to v0.107.27 the container starts without any errors, works as expected.

@dmmmuse
Copy link

dmmmuse commented Apr 13, 2023

I am experiencing the same issue running AGH Version: v0.107.28 on a k8s cluster. When I revert to Version: v0.107.27, everything works perfectly. Same error as stated above

@Turbine1313
Copy link

Same problem here after upgrade to v0.107.28. Running on portainer via debian.

@maxcanna
Copy link

Set both CMD and ENTRYPOINT to the default. Watchtower during the update carries the settings from the old version (even if they were default) and those are incompatible with the new one

@Turbine1313
Copy link

Set both CMD and ENTRYPOINT to the default. Watchtower during the update carries the settings from the old version (even if they were default) and those are incompatible with the new one

This is what I have there now :
CMD -c /opt/adguardhome/conf/AdGuardHome.yaml -h 0.0.0.0 -w /opt/adguardhome/work
ENTRYPOINT /sbin/tini --

What should I use instead ?

@maxcanna
Copy link

Set both CMD and ENTRYPOINT to the default. Watchtower during the update carries the settings from the old version (even if they were default) and those are incompatible with the new one

This is what I have there now : CMD -c /opt/adguardhome/conf/AdGuardHome.yaml -h 0.0.0.0 -w /opt/adguardhome/work ENTRYPOINT /sbin/tini --

What should I use instead ?

As I said, do not set them. Leave them as specified in the image

@ovizii
Copy link

ovizii commented Apr 13, 2023

Set both CMD and ENTRYPOINT to the default. Watchtower during the update carries the settings from the old version (even if they were default) and those are incompatible with the new one

OK, so what do we do now watchtower has updated the container? Stopping and removing it and then starting it again doesn't fix the problem nor is there any error to be seen in its logs.

@maxcanna
Copy link

Set both CMD and ENTRYPOINT to the default. Watchtower during the update carries the settings from the old version (even if they were default) and those are incompatible with the new one

OK, so what do we do now watchtower has updated the container? Stopping and removing it and then starting it again doesn't fix the problem nor is there any error to be seen in its logs.

As I told you, you've to create the container w/o setting those values. If you start it with the same values set it's obviously gonna crash again 🤷🏻
BTW the error is clearly visible in the log present in the OP

@ovizii
Copy link

ovizii commented Apr 13, 2023

My bad, wrong thread, sorry about that :-( I had too many tabs open, replied to the wrong thread.

@szjani
Copy link
Author

szjani commented Apr 13, 2023

Thanks @maxcanna , I'm going to re-create the container after working hours and see if it works.

I'm wondering if this breaking change is intentional and similar issues can happen in the future. If so, then using Watchtower to update AdGuard Home may be not the right approach.

@ovizii
Copy link

ovizii commented Apr 13, 2023

@szjani just pay attention as there is another issue with the latest update related to bind_hosts and the new healthchecks: #5714

@Aad3229
Copy link

Aad3229 commented Apr 13, 2023

Same problem here after upgrade to v0.107.28 ([FATAL tini (9)] exec -h failed: No such file or directory). Running on Synology DS218+ in Docker

@maxcanna
Copy link

Same problem here after upgrade to v0.107.28 ([FATAL tini (9)] exec -h failed: No such file or directory). Running on Synology DS218+ in Docker

Did you try #5713 (comment) ?

@Aad3229
Copy link

Aad3229 commented Apr 13, 2023

Same problem here after upgrade to v0.107.28 ([FATAL tini (9)] exec -h failed: No such file or directory). Running on Synology DS218+ in Docker

Did you try #5713 (comment) ?

I do not use Watchtower. As always I manually updated the image, stopped and reset the container. Unfortunately it does not start now. I do not know how or where to do the actions described in #5713

@Laibalion
Copy link

Laibalion commented Apr 13, 2023

@Aad3229 , I was in the same boat as you. Afaik there is no way to alter the Execution Command of the container once it is created, which is what you need to do.
So what you can do is export the configuration of the container to your local computer, for reference.
Delete the existing container
Create new container and set it up with the needed volume bindings, network mode, and env variables (ie. TZ etc) you in the container you deleted. Here you can use the exported json from before as reference.

@NebzHB
Copy link

NebzHB commented Apr 14, 2023

Same error on synology. CMD and ENTRYPOINT are not set anywhere in Synology GUI.

@Laibalion : recreating the container do works ! thank you !

@ainar-g ainar-g added needs investigation Needs to be reproduced reliably. docker Docker-related issues labels Apr 14, 2023
@ainar-g ainar-g changed the title AGH v0.107.28 does not start AGH v0.107.28 docker image does not start Apr 14, 2023
@ainar-g ainar-g pinned this issue Apr 14, 2023
@JaZo
Copy link

JaZo commented Apr 15, 2023

Easiest way to fix this on a Synology:

  1. Export the settings to JSON;
  2. Change cmd to "/opt/adguardhome/AdGuardHome --no-check-update -c /opt/adguardhome/conf/AdGuardHome.yaml -h 0.0.0.0 -w /opt/adguardhome/work" with your favorite text editor (as taken from the Dockerfile);
  3. Delete the existing container;
  4. Import the JSON file.

@ovar0409
Copy link

FYI, I had the same problem after upgrade to v0.107.28 or .29. Also running on Synology DS218+ in Docker.
In Portainer I duplicated the container, and in "Advanced Container Settings" I changed the Command and the Entrypoint to Default as indicated by maxcanna. AGH is now running again...

@szjani
Copy link
Author

szjani commented Apr 28, 2023

I am closing this issue. There is a solution, I don't know if using watchtower to update AGH is a good idea though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Docker-related issues
Projects
None yet
Development

No branches or pull requests