Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make field "Bootstrap DNS servers" accept upstream syntax #6126

Open
4 tasks done
Ziris85 opened this issue Aug 21, 2023 · 3 comments
Open
4 tasks done

Make field "Bootstrap DNS servers" accept upstream syntax #6126

Ziris85 opened this issue Aug 21, 2023 · 3 comments

Comments

@Ziris85
Copy link

Ziris85 commented Aug 21, 2023

Prerequisites

Platform (OS and CPU architecture)

Linux, AMD64 (aka x86_64)

Installation

Snapcraft

Setup

On one machine

AdGuard Home version

0.107.36

Action

I attempted to add comments to the "Bootstrap DNS servers" text box. Attempting to apply or test the upstreams results in an error:

Error: control/dns_config | checking bootstrap # 9.9.9.10: invalid address: bootstrap # 9.9.9.10:53: ParseAddr("# 9.9.9.10"): unexpected character (at "# 9.9.9.10") | 400

Contents that I'm testing with are:

# 9.9.9.10
149.112.112.10
2620:fe::10
2620:fe::fe:10

Expected result

The "Examples" section immediately above the textbox indicate that lines leading with # are proper syntax for comments, so I would expect the syntax to validate and for AdGuard to ignore the lines indicated as comments

Actual result

AdGuard fails to validate the config and refuses to apply the settings

Additional information and/or screenshots

No response

@Ziris85
Copy link
Author

Ziris85 commented Aug 21, 2023

Realized my initial config wasn't actually valid, so tested again with valid configs and verified the issue is still present. Updated initial comment with what should otherwise be valid configs

@ainar-g
Copy link
Contributor

ainar-g commented Aug 22, 2023

The bootstrap field only really accepts IP addresses, if I recall correctly. It's not a proper upstream config currently, so no comments and no domain-specific rules. At the very least, the UI needs to be updated to make that clear.

@ainar-g ainar-g added this to the v0.107.37 milestone Aug 22, 2023
@ainar-g ainar-g changed the title Comments in "dns_config" don't validate Make field "Bootstrap DNS servers" accept upstream syntax Sep 7, 2023
@ainar-g
Copy link
Contributor

ainar-g commented Sep 7, 2023

The UI changes will arrive in v0.107.37. I will retitle this issue to be about the support for the full upstream syntax, including comments.

@ainar-g ainar-g added P3: Medium and removed P4: Low labels Sep 7, 2023
@ainar-g ainar-g modified the milestones: v0.107.37, v0.108.0 Sep 7, 2023
@ainar-g ainar-g assigned ainar-g and unassigned Mizzick Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants