Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No comments in Bootstrap DNS servers field #6173

Closed
4 tasks done
saint-lascivious opened this issue Sep 7, 2023 · 1 comment
Closed
4 tasks done

No comments in Bootstrap DNS servers field #6173

saint-lascivious opened this issue Sep 7, 2023 · 1 comment
Labels
duplicate Duplicate or merged issues.

Comments

@saint-lascivious
Copy link

Prerequisites

Platform (OS and CPU architecture)

Linux, ARM64

Installation

Other (please mention in the description)

Setup

Other (please mention in the description)

AdGuard Home version

93d7be1

Action

Attempted to use comments in Bootstrap DNS servers field.

# comment test one
192.168.1.10:5335
# comment test two
192.168.1.20:5335

Expected result

Comments accepted in Bootstrap DNS servers field (and preferably for all comments to be handled uniformly in terms of styling for all fields).

Actual result

Comments rejected in Bootstrap DNS servers field.

Error: control/dns_config | checking bootstrap # comment test one: invalid address: bootstrap # comment test one:53: ParseAddr("# comment test one"): unable to parse IP | 400

Additional information and/or screenshots

Self build of 93d7be1, personal AGH instances behind dnsdist on aarch64 Ubuntu Server 23.04.

Upstream, Fallback, Custom etc. DNS server fields all accept comments (though only Upstreams features comments styled in grey). The Boostrap DNS servers field appears to be parsed differently.

@ainar-g
Copy link
Contributor

ainar-g commented Sep 7, 2023

Merging into #6126.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Duplicate or merged issues.
Projects
None yet
Development

No branches or pull requests

2 participants