Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to update and unable to execute #6132

Closed
4 tasks done
bestpika opened this issue Aug 23, 2023 · 4 comments
Closed
4 tasks done

Unable to update and unable to execute #6132

bestpika opened this issue Aug 23, 2023 · 4 comments
Assignees
Milestone

Comments

@bestpika
Copy link

bestpika commented Aug 23, 2023

Prerequisites

Platform (OS and CPU architecture)

Windows, AMD64 (aka x86_64)

Installation

GitHub releases or script from README

Setup

On one machine

AdGuard Home version

v0.108.0-a.658+2bfc9fcb

Action

.\AdGuardHome.exe --update -v
.\AdGuardHome.exe -v

Expected result

Update or execute.

Actual result

Update

2023/08/23 19:55:22.869561 13120#1 [info] AdGuard Home, version v0.108.0-a.658+2bfc9fcb
2023/08/23 19:55:22.899829 13120#1 [debug] current working directory is C:\AGH
2023/08/23 19:55:22.900370 13120#1 [debug] reading config file: C:\AGH\AdGuardHome.yaml
2023/08/23 19:55:22.901449 13120#1 [debug] github.com/AdguardTeam/AdGuardHome/internal/home.upgradeConfig(): got schema version 25
2023/08/23 19:55:22.901449 13120#1 [debug] reading config file: C:\AGH\AdGuardHome.yaml
2023/08/23 19:55:22.902653 13120#1 [info] tls: using default ciphers
2023/08/23 19:55:22.902653 13120#1 [debug] hosts container: starting
2023/08/23 19:55:22.902653 13120#1 [debug] hosts container: refreshing
2023/08/23 19:55:22.903193 13120#1 [fatal] initing hosts container: hosts container: refreshing : checking "Windows/system32/drivers/etc/hosts": parsing: 21 errors: "line 1: line is empty", "line 2: line is empty", "line 3: line is empty", "line 4: line is empty", "line 5: line is empty", "line 6: line is empty", "line 7: line is empty", "line 8: line is empty", "line 9: line is empty", "line 10: line is empty", "line 11: line is empty", "line 12: line is empty", "line 13: line is empty", "line 14: line is empty", "line 15: line is empty", "line 16: line is empty", "line 17: line is empty", "line 18: line is empty", "line 19: line is empty", "line 20: line is empty", "line 21: line is empty"

Run

2023/08/23 19:58:12.419459 3700#1 [info] AdGuard Home, version v0.108.0-a.658+2bfc9fcb
2023/08/23 19:58:12.452962 3700#1 [debug] current working directory is C:\AGH
2023/08/23 19:58:12.452962 3700#1 [debug] reading config file: C:\AGH\AdGuardHome.yaml
2023/08/23 19:58:12.453990 3700#1 [debug] github.com/AdguardTeam/AdGuardHome/internal/home.upgradeConfig(): got schema version 25
2023/08/23 19:58:12.454505 3700#1 [debug] reading config file: C:\AGH\AdGuardHome.yaml
2023/08/23 19:58:12.455044 3700#1 [info] tls: using default ciphers
2023/08/23 19:58:12.455561 3700#1 [debug] hosts container: starting
2023/08/23 19:58:12.455561 3700#1 [debug] hosts container: refreshing
2023/08/23 19:58:12.456081 3700#1 [fatal] initing hosts container: hosts container: refreshing : checking "Windows/system32/drivers/etc/hosts": parsing: 21 errors: "line 1: line is empty", "line 2: line is empty", "line 3: line is empty", "line 4: line is empty", "line 5: line is empty", "line 6: line is empty", "line 7: line is empty", "line 8: line is empty", "line 9: line is empty", "line 10: line is empty", "line 11: line is empty", "line 12: line is empty", "line 13: line is empty", "line 14: line is empty", "line 15: line is empty", "line 16: line is empty", "line 17: line is empty", "line 18: line is empty", "line 19: line is empty", "line 20: line is empty", "line 21: line is empty"

Additional information and/or screenshots

The message says that there is a problem with my hosts, but in reality there is no error.
It is an error in your application’s interpretation of the content.

Here is the content of my hosts file.

# Copyright (c) 1993-2009 Microsoft Corp.
#
# This is a sample HOSTS file used by Microsoft TCP/IP for Windows.
#
# This file contains the mappings of IP addresses to host names. Each
# entry should be kept on an individual line. The IP address should
# be placed in the first column followed by the corresponding host name.
# The IP address and the host name should be separated by at least one
# space.
#
# Additionally, comments (such as these) may be inserted on individual
# lines or following the machine name denoted by a '#' symbol.
#
# For example:
#
#      102.54.94.97     rhino.acme.com          # source server
#       38.25.63.10     x.acme.com              # x client host

# localhost name resolution is handled within DNS itself.
#	127.0.0.1       localhost
#	::1             localhost

It is obvious that files without content but only comments will be considered problematic.
Because after I tried adding a line of content, it was able to run properly.

@bestpika
Copy link
Author

Could #6114 be the same issue?

adguard pushed a commit that referenced this issue Aug 23, 2023
Merge in DNS/adguard-home from 6132-fix-hosts-startup to master

Updates #6132.

Squashed commit of the following:

commit 7495e62
Merge: c5d99bc 4b04c62
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed Aug 23 18:50:14 2023 +0300

    Merge branch 'master' into 6132-fix-hosts-startup

commit c5d99bc
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed Aug 23 18:01:17 2023 +0300

    filtering: fix hosts results

commit b7acf26
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed Aug 23 17:34:43 2023 +0300

    all: revert changes of log of changes

commit 293240d
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed Aug 23 17:30:07 2023 +0300

    aghnet: imp logs

commit d1f7d73
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed Aug 23 17:19:54 2023 +0300

    aghnet: impl handle set

commit b643793
Author: Eugene Burkov <E.Burkov@AdGuard.COM>
Date:   Wed Aug 23 17:00:05 2023 +0300

    aghnet: fix initial refresh
@EugeneOne1
Copy link
Member

@bestpika, hello and thanks for the report. We've pushed the edge release that should fix this issue, could you please try it and tell if AdGuard Home starts properly?

@bestpika
Copy link
Author

@EugeneOne1 I have updated to v0.108.0-a.663+2b901931 and it seems to start up normally when tested.

@EugeneOne1
Copy link
Member

@bestpika, great to hear. We'll close the issue for now, but you're welcome to reopen it if the issue persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants