Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not display non significant Average processing time #6220

Closed
3 tasks done
Gandulf78 opened this issue Sep 14, 2023 · 5 comments
Closed
3 tasks done

Do not display non significant Average processing time #6220

Gandulf78 opened this issue Sep 14, 2023 · 5 comments
Assignees
@EugeneOne1 @schzhn
Labels
enhancement external libs Issues that require changes in external libraries. P3: Medium
Milestone
v0.107.41

Comments

@Gandulf78
Copy link

Gandulf78 commented Sep 14, 2023 •
edited
Loading

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to request a feature or enhancement and not ask a question

The problem

I have set up two fallback resolvers on Adguard Home (v0.108.0-b.46) and I get average processing time of 28343 ms just for 1 query for each of them.
Besides this value seems strange to me, it may also include the initial query to the DNS server and not only the query to the fallback?
IMG_20231013_132649.jpg

Proposed solution

Do not display non statically significant average processing time.

Alternatives considered and additional information

No response
@Werewolfke
Copy link

same here, indeed it is a wrong measurement.
(i think) As it is a fall back it does not sent from the instant its needed, but only after x amount of seconds of not getting a responds from the main set dns resolvers. and only after that it sends to the fallback... so if it starts counting from the query request, it indeed will take so long before the dns resolver has processed it... bcs it has not recived it for most of the time too.
(so... no its not the dns resolver thats slow, its just a miss calculation for the fallback dns resolvers.)

But if anyone reads this i would like to add to theis too, that it always shows the slowest processed times first... i would like i to be set automatically or atleast save that i set it so that it show the fastest processing ones first.

@CYAsistemas
Copy link

Same here, in a beta version
image

@ainar-g ainar-g added this to the v0.107.39 milestone Sep 18, 2023
@ainar-g
Copy link
Contributor

ainar-g commented Sep 18, 2023

There seem to be two things at play here: the total duration of an upstream query and the duration of the query to the fallback. Currently, the entire duration of a query, including the failed attempts to reach the main upstreams is counted.

@EugeneOne1, I feel like this needs to be fixed in the DNS proxy module somehow.

@ainar-g ainar-g added the external libs Issues that require changes in external libraries. label Sep 18, 2023
@Werewolfke
Copy link

(update) Was fixed for a few versions but got it back since last 2 or 3 alpha versions. Now I'm on v0.108.0-a.725+5fa11567
And it's back...

@ainar-g ainar-g mentioned this issue Oct 12, 2023
Closed
4 tasks
adguard pushed a commit to AdguardTeam/dnsproxy that referenced this issue Oct 31, 2023
@schzhn
Pull request 292: 6220-query-duration
8d20902 
Updates AdguardTeam/AdGuardHome#6220.

Squashed commit of the following:

commit 3d437e6
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Tue Oct 31 14:20:56 2023 +0300

    proxy: imp docs

commit 543a9a9
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Tue Oct 31 13:22:07 2023 +0300

    proxy: imp log msg

commit 20a0dda
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Mon Oct 30 15:21:47 2023 +0300

    proxy: imp docs

commit b6c4409
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Thu Oct 26 16:35:47 2023 +0300

    proxy: add query duration
adguard pushed a commit that referenced this issue Nov 9, 2023
@schzhn
Pull request 2054: 6220-average-processing-time
d386261 
Updates #6220.

Squashed commit of the following:

commit 2ad8797
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Thu Nov 9 13:55:09 2023 +0300

    all: upd go

commit 387200c
Merge: 37f2855 f8fe9bf
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Thu Nov 9 13:49:59 2023 +0300

    Merge branch 'master' into 6220-average-processing-time

commit 37f2855
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Wed Nov 8 17:08:13 2023 +0300

    client: upd locales

commit a09be41
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Tue Nov 7 20:46:24 2023 +0300

    all: imp docs

commit f0b85ac
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Fri Nov 3 14:17:32 2023 +0300

    all: add todo

commit 48a5879
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Fri Nov 3 13:38:14 2023 +0300

    all: add upstream time

commit 4d7431c
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Tue Oct 31 17:27:19 2023 +0300

    all: upd chlog

commit 040b6b9
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Tue Oct 31 15:42:04 2023 +0300

    all: imp average processing time
@schzhn
Copy link
Member

schzhn commented Nov 9, 2023

The upcoming v0.107.41 release will contain improved average upstream response time calculation.

@ainar-g ainar-g closed this as completed Nov 13, 2023
@ainar-g ainar-g modified the milestones: v0.107.42, v0.107.41 Nov 13, 2023
annguyen0 pushed a commit to annguyen0/AdGuardHome that referenced this issue Nov 27, 2023
@schzhn @annguyen0
Pull request 2054: 6220-average-processing-time
b865e85 
Updates AdguardTeam#6220.

Squashed commit of the following:

commit 2ad8797
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Thu Nov 9 13:55:09 2023 +0300

    all: upd go

commit 387200c
Merge: 37f2855 f8fe9bf
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Thu Nov 9 13:49:59 2023 +0300

    Merge branch 'master' into 6220-average-processing-time

commit 37f2855
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Wed Nov 8 17:08:13 2023 +0300

    client: upd locales

commit a09be41
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Tue Nov 7 20:46:24 2023 +0300

    all: imp docs

commit f0b85ac
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Fri Nov 3 14:17:32 2023 +0300

    all: add todo

commit 48a5879
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Fri Nov 3 13:38:14 2023 +0300

    all: add upstream time

commit 4d7431c
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Tue Oct 31 17:27:19 2023 +0300

    all: upd chlog

commit 040b6b9
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Tue Oct 31 15:42:04 2023 +0300

    all: imp average processing time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

@schzhn schzhn

Labels
enhancement external libs Issues that require changes in external libraries. P3: Medium
Projects
None yet
Milestone
v0.107.41
Development

No branches or pull requests
6 participants
@ainar-g @EugeneOne1 @Gandulf78 @Werewolfke @schzhn @CYAsistemas