ipset - unexpected family ProtoUnspec [v0.108.0-b.49-50]

[odcold]

Prerequisites

• I have checked the Wiki and Discussions and found no answer

• I have searched other issues and found no duplicates

• I want to report a bug and not ask a question or ask for help

• I have set up AdGuard Home correctly and configured clients to use it. (Use the Discussions for help with installing and configuring clients.)

Platform (OS and CPU architecture)

Linux, MIPS LE

Installation

GitHub releases or script from README

Setup

On one machine

AdGuard Home version

AdGuard Home v0.108.0-b.49

Action

ipset create bypass hash:ip

ipset file is filled with domains

ipset_file: /opt/etc/AdGuardHome/ipset.conf

Expected result

adresses are added to ipset

Actual result

2023/11/14 10:18:11.705099 [error] dnsforward: ipset: adding host ips: unexpected family ProtoUnspec for ipset "bypass"
2023/11/14 10:18:16.576093 [error] dnsforward: ipset: adding host ips: unexpected family ProtoUnspec for ipset "bypass"
2023/11/14 10:18:29.545826 [error] dnsforward: ipset: adding host ips: unexpected family ProtoUnspec for ipset "bypass"
2023/11/14 10:18:29.574250 [error] dnsforward: ipset: adding host ips: unexpected family ProtoUnspec for ipset "bypass"

Additional information and/or screenshots

rolling back to beta 48 fixes this issue

[ainar-g]

@schzhn, please investigate.

[schzhn]

Hello, @odcold, could you please help us investigate the issue?

• What is version of ipset (ipset --version)?
• How does output of the ipset list bypass looks like (you can strip Members)?
• Does the error message disappear if you specify the family (ipset create bypass hash:ip family ipv4)?

[odcold]

• Does the error message disappear if you specify the family (ipset create bypass hash:ip family ipv4)?

Thanks, adding this argument fixes the error.
Everything works perfect now

[schzhn]

Thanks for your report @odcold.
We will improve the documentation and error handling with the next updates.

[odcold]

found another related issue. If ipset is created with timeout param for ex:
ipset create bypass hash:ip family ipv4 timeout 86400

error will occur after timeout is expired
2023/11/25 15:16:52.720545 [fatal] dnsServer.Prepare: preparing ipset settings: initializing ipset: ipset: getting ipsets: getting ipsets from config line at idx 0: "bypass" unexpected ipset family "ProtoUnspec"

but ipset is present and filled with addresses

~ # ipset list bypass
Name: bypass
Type: hash:ip
Revision: 4
Header: family inet hashsize 1024 maxelem 65536 timeout 86400
Size in memory: 16412
References: 2

[dorner365]

I'm seeing the same fatal error as @odcold in an identical configuration where the ipsets are created without additional parameters. The ipset list command Type, Revision and Header are identical.
V0.108.0-b.49 works without errors.

[schzhn]

@odcold, unfortunately, we cannot reproduce that.
Could you please check if v0.107.39 does work for you?

rolling back to beta 48 fixes this issue

[odcold]

@schzhn sorry for misinformation the issue was not timeout related
beta 108v50 has a memory leak which caused the error above for some reason
i cant test the edge build containing the fix - its not available for mipsle
please don't close this issue i'll try to reproduce the steps which caused it in the next beta with fix included

[schzhn]

@dorner365, in v0.108.0-b.49 there was no ipset configuration check at startup, so you get the ipset related errors in runtime.

[dorner365]

I have this error on 2 different systems (of which one is Ubuntu 20.04.6 LTS). The error as it stands is misleading - what is 'unexpected ipset family "ProtoUnspec"' in the runtime context or as error handling?
Outside AdGuardHome the ipsets load and perform selective routing as expected.

[schzhn]

@dorner365, thank you for the additional information.
In v0.108.0-b.49 you can see non-fatal errors like this at runtime in the log
2023/11/29 19:12:30.109275 [error] dnsforward: ipset: adding host ips: unexpected family ProtoUnspec for ipset "bypass"
We are investigating an issue.

[odcold]

@schzhn i've found out what is causing errors in b49
2023/11/29 15:07:18.904950 [error] dnsforward: ipset: adding host ips: unexpected family ProtoUnspec for ipset "bypass"
if ipset file is modified (entry added) and adguard service is restarted the error will occur
after the ipset destroy command and creating it again there are no errors after agh restart

[schzhn]

We've pushed the edge release containing some improvements.
You can find version for MIPS-LE on this page.
@odcold, @dorner365, could you please check does it work for you?

[odcold]

@schzhn thanks for the build but unfortunately the error persists
installed new version, restarted service and:
23/11/30 15:40:36.161735 [error] dnsforward: ipset: adding host ips: "bypass" "" unexpected family "ProtoUnspec"
2023/11/30 15:40:53.859436 [error] dnsforward: ipset: adding host ips: "bypass" "" unexpected family "ProtoUnspec"
2023/11/30 15:40:56.290573 [error] dnsforward: ipset: adding host ips: "bypass" "" unexpected family "ProtoUnspec"
Upd1
After ipset destroy ipset create and restarting agh - everything works as expected
Upd2
adding new entries to ipset file and restarting agh service still cause errors as mentioned in previous message

[dorner365]

Seems alright on Ubuntu 20.04.6:

????@????:/opt/AdGuardHome# systemctl status AdGuardHome
● AdGuardHome.service - AdGuard Home: Network-level blocker
Loaded: loaded (/etc/systemd/system/AdGuardHome.service; enabled; vendor preset: enabled)
Active: active (running) since Thu 2023-11-30 11:12:48 EST; 19s ago
Process: 68510 ExecStartPre=/bin/mkdir -p /var/log/ (code=exited, status=0/SUCCESS)
Main PID: 68511 (AdGuardHome)
Tasks: 8 (limit: 4554)
Memory: 52.1M
CGroup: /system.slice/AdGuardHome.service
└─68511 /opt/AdGuardHome/AdGuardHome -s run

Nov 30 11:12:48 systemd[1]: Starting AdGuard Home: Network-level blocker...
Nov 30 11:12:48 systemd[1]: Started AdGuard Home: Network-level blocker.

????@????:/opt/AdGuardHome# ./AdGuardHome --version
AdGuard Home, version v0.108.0-a.779+2965d1fb

No [fatal] error anymore. Thank you!

EDIT - both systems are arm64 and work well with v0.108.0-a.780+75cb9d41.

[odcold]

updated to
Version:
v0.108.0-a.780+75cb9d41
no errors so far

[odcold]

Encountered an error after changing upstream dns servers, and applying changes. But can't reproduce it again, trying to investigate with verbose logs

[odcold]

and it happened again after changing upstream servers
verbose logs are not really informative for ipset:

2023/12/05 17:11:24.741262 3034#1702488 [debug] dnsforward: finished processing filtering after resp
2023/12/05 17:11:24.742220 3034#1702488 [debug] dnsforward: ipset: started processing
2023/12/05 17:11:24.742691 3034#1702489 [debug] dnsforward: finished processing filtering before req
2023/12/05 17:11:24.743350 3034#1702488 [debug] ipset: starting processing
2023/12/05 17:11:24.743555 3034#1702489 [debug] dnsforward: started processing local ptr
2023/12/05 17:11:24.744619 3034#1702488 [debug] ipset: found 1 sets
2023/12/05 17:11:24.744658 3034#1702462 [debug] dnsproxy: upstream quic://unfiltered.adguard-dns.com:853 exchanged ;signalr.digiseller.ru.	IN	 HTTPS successfully in 67.020228ms
2023/12/05 17:11:24.744736 3034#1702489 [debug] dnsforward: finished processing local ptr
2023/12/05 17:11:24.745531 3034#1702488 [error] dnsforward: ipset: adding host ips: "bypass" "" unexpected family "ProtoUnspec"

maybe the error occurs when an answer for certain request differs depending on upstream dns

[schzhn]

@odcold, could you please take a look at the edge version v0.108.0-a.785+214175eb?

[dorner365]

With the v0.108.0-b.51 all related log entries now are [info]; no more errors. On my systems the original ipset ProtoUnspec is resolved. Thank you.

[odcold]

@schzhn since v0.108.0-a.785+214175eb and after updating to 108.b.51 no errors so far

[schzhn]

We are closing this issue. Please let us know if the problem persists.