Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less Obtrusive Block/Unblock Button in Query Log #684

Closed
ghost opened this issue Mar 29, 2019 · 6 comments
Closed

Less Obtrusive Block/Unblock Button in Query Log #684

ghost opened this issue Mar 29, 2019 · 6 comments
Assignees
@IldarKamalov
Labels
enhancement P4: Low UI
Milestone
v0.107.40

Comments

@ghost
Copy link

ghost commented Mar 29, 2019

Screen Shot 2019-03-30 at 01 28 20

As you can see by the screenshot the block/unblock button is covering up the IP of the client when the hostname has been set making it impossible to identify the last set of numerals.

I recommend adding an extra column for the button.

Note: For the purpose of aesthetics, if an extra column is created a way of highlighting each line as you hover over it will be needed as the block/unblock button will no longer act as this indicator.
@ghost
Copy link

ghost commented Sep 22, 2019

That belongs to both desktop and mobile when browser window size small #978

@szolin szolin mentioned this issue Oct 31, 2019
Open
@Aikatsui Aikatsui mentioned this issue Oct 4, 2020
Open
24 tasks
@user9931
Copy link

going to hit "new issue" button but find this, its mostly the same

This block/unblock button placement also pain of using on touchscreen devices, often instead of scrolling - block/unblock happends. Please, make it static for mobile device so at least it will be to avoid false clicks

@ainar-g ainar-g changed the title [Feature Request] Less Obtrusive Block/Unblock Button in Query Log Less Obtrusive Block/Unblock Button in Query Log Apr 19, 2023
@ainar-g ainar-g added enhancement and removed bug labels Apr 19, 2023
@ainar-g ainar-g added this to the v0.107.30 milestone Apr 19, 2023
adguard pushed a commit that referenced this issue Oct 16, 2023
@IldarKamalov
Pull request: 684 move block/unblock button to the tooltip menu
413f484 
Updates #684

Squashed commit of the following:

commit 2c5ac44
Merge: 0fce61d 733d6c1
Author: Ildar Kamalov <ik@adguard.com>
Date:   Mon Oct 16 10:08:58 2023 +0300

    Merge branch 'master' into ADG-7200

commit 0fce61d
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Oct 13 16:38:13 2023 +0300

    fix dashboard clients table block/unblock button

commit ef5d72f
Merge: f49281b 506d713
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Oct 13 16:16:21 2023 +0300

    Merge branch 'master' into ADG-7200

commit f49281b
Author: Ildar Kamalov <ik@adguard.com>
Date:   Thu Oct 12 11:25:05 2023 +0300

    fix disabled

commit 0031861
Author: Ildar Kamalov <ik@adguard.com>
Date:   Thu Oct 12 11:20:50 2023 +0300

    fix icon color

commit 2916937
Author: Ildar Kamalov <ik@adguard.com>
Date:   Thu Oct 12 11:15:55 2023 +0300

    changelog

commit 34493c9
Merge: d3267bb d3fabdd
Author: Ildar Kamalov <ik@adguard.com>
Date:   Thu Oct 12 11:13:43 2023 +0300

    Merge branch 'master' into ADG-7200

commit d3267bb
Merge: 58a6c76 6a36615
Author: Ildar Kamalov <ik@adguard.com>
Date:   Wed Oct 11 16:46:39 2023 +0300

    Merge branch 'master' into ADG-7200

commit 58a6c76
Author: Ildar Kamalov <ik@adguard.com>
Date:   Wed Oct 11 16:46:13 2023 +0300

    ADG-7200 move block/unblock button to the tooltip menu
@ainar-g
Copy link
Contributor

ainar-g commented Oct 17, 2023

The latest Edge and Beta releases have a better UI with a tooltip menu, so we'll close this. If anyone has issues with those, please file new issues with descriptions and screenshots.

@ainar-g ainar-g closed this as completed Oct 17, 2023
@ainar-g ainar-g assigned IldarKamalov and unassigned Blakhard Oct 17, 2023
@ainar-g ainar-g modified the milestones: v0.107.41, v0.107.40 Oct 18, 2023
@hexclann
Copy link

@ainar-g Can we please have an option to disable this feature and have the block button always visible? I get around 5 million queries every month from 15+ devices and I actively use the query log page to block the domains and moving the button to tooltip will add an extra step in the process.

The old UI was much more usable than the current one.

@agneevX
Copy link
Contributor

agneevX commented Oct 19, 2023

This is good but there's still too much space for clients in the default view:

Screenshot

@lucktu
Copy link

lucktu commented Oct 21, 2023

I think that after the modification, the use of the forbidden function is not as convenient as before, I suggest this one to restore back.

I'll stick with AdGuard Home v0.107.39.

annguyen0 pushed a commit to annguyen0/AdGuardHome that referenced this issue Nov 27, 2023
@IldarKamalov @annguyen0
Pull request: 684 move block/unblock button to the tooltip menu
d1e969c 
Updates AdguardTeam#684

Squashed commit of the following:

commit 2c5ac44
Merge: 0fce61d 733d6c1
Author: Ildar Kamalov <ik@adguard.com>
Date:   Mon Oct 16 10:08:58 2023 +0300

    Merge branch 'master' into ADG-7200

commit 0fce61d
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Oct 13 16:38:13 2023 +0300

    fix dashboard clients table block/unblock button

commit ef5d72f
Merge: f49281b 506d713
Author: Ildar Kamalov <ik@adguard.com>
Date:   Fri Oct 13 16:16:21 2023 +0300

    Merge branch 'master' into ADG-7200

commit f49281b
Author: Ildar Kamalov <ik@adguard.com>
Date:   Thu Oct 12 11:25:05 2023 +0300

    fix disabled

commit 0031861
Author: Ildar Kamalov <ik@adguard.com>
Date:   Thu Oct 12 11:20:50 2023 +0300

    fix icon color

commit 2916937
Author: Ildar Kamalov <ik@adguard.com>
Date:   Thu Oct 12 11:15:55 2023 +0300

    changelog

commit 34493c9
Merge: d3267bb d3fabdd
Author: Ildar Kamalov <ik@adguard.com>
Date:   Thu Oct 12 11:13:43 2023 +0300

    Merge branch 'master' into ADG-7200

commit d3267bb
Merge: 58a6c76 6a36615
Author: Ildar Kamalov <ik@adguard.com>
Date:   Wed Oct 11 16:46:39 2023 +0300

    Merge branch 'master' into ADG-7200

commit 58a6c76
Author: Ildar Kamalov <ik@adguard.com>
Date:   Wed Oct 11 16:46:13 2023 +0300

    ADG-7200 move block/unblock button to the tooltip menu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IldarKamalov IldarKamalov

Labels
enhancement P4: Low UI
Projects
None yet
Milestone
v0.107.40
Development

No branches or pull requests
8 participants
@IldarKamalov @ainar-g @Blakhard @ameshkov @agneevX @lucktu @hexclann @user9931