Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add filters and hosts blocklists from local hard disk #817

Closed
ghost opened this issue Jun 7, 2019 · 12 comments
Closed

Comments

@ghost
Copy link

ghost commented Jun 7, 2019

  • This feature shouldn't affect to low-end devices disk or ram
  • Detect blocklists changes automatically
@anindyamaiti
Copy link

You can have a web server running on 127.0.0.1 and serving those lists. Then 'add filter' like you would do for any other online list and use the localhost address in the URL field. Have different files for categorization.

@ghost
Copy link
Author

ghost commented Jul 21, 2019

@anindyamaiti complex task :)

@anindyamaiti
Copy link

I was just giving an alternate solution that will work right now, because I didn't see any response from the devs yet.

Also, setting up a web server is not as complex as you make it sound. It takes couple of package installations and less than 5 minutes of time. I recommend trying out lighttpd if you have resource constraints:

sudo apt-get update
sudo apt-get install lighttpd

@ameshkov
Copy link
Member

however no milestone yet, likely we have to wait long time.

As of usual, it depends on the number of upvotes:)

@ghost
Copy link
Author

ghost commented Sep 23, 2019

Feature Highlights:

  • Create local filter procedure
     
    Screenshot_5

    • Tags help assign specific filters to a client or multiple clients easily. See Different client filter configuration #435 It has advantage than use filter name because we can set several tags to each filter or use same tag name to multiple filters)
    • Global filter is an option to apply specific filter for all connected devices without keep as inactive except used by 'Client'
       
  • Update (or Edit)
    (The same button(icon) able to use for update each remote and local filter manually. See [Feature Request] Update selected filters manually #820
    if it a local filter then open the blocklist, whitelist window)

    • Maintain a local filter (add or remove rules)
         Let to maintain each local filter in pop up window. eg: 500x500 size may suitable for average screen however keep in mind to auto resize depend on window or screen size include for mobile devices.
       
      Screenshot_8
      (Search component helps user to find specific rule quickly without scroll huge list and reduce mistakenly add duplicate)

    • Detect invalid rules.
         Do not allow user to save filter with invalid rules and notify for re-correct them
       
      65457210-41eb7280-de75-11e9-90c8-48ceb8b1685c

    • Detect duplicate rules.
          Test/Check domain against Filter rules #856 also helps for detect existing rules however it doesnt meet the exact requirement
       
      65457210-41eb7280-de75-11e9-90c8-48ceb8b1685c (1)

    • Toolbox
         No more text editors, tools, scripts.
       
      65457210-41eb7280-de75-11e9-90c8-48ceb8b1685c
      [1] Just add required rule then only necessary to type the domain.
      [2] It means apply a rule for bulk at once
      [3] Find duplicate rules within that local list
      [4] Find duplicate rules from all added filter lists.
      [5] Auto arrange feature must identify Domains, IPs separately also necessary to remove invalid rules belong to those and rest of words or numbers must list as comments
      [6] Last feature helps to remove everything may not valid as Domain or IP
       and more......

@ameshkov
Copy link
Member

ameshkov commented Mar 3, 2020

@Archivebase most of the comments should be separate feature requests.

Regarding adding lists from local hard disk, we'll do this in v0.102:

  1. Change text on the "New blocklist/whitelist" dialogs: "Enter URL or path to the blocklist"
  2. Please note that you will still need to click "Check for updates" when you change the local list

@ghost
Copy link
Author

ghost commented Mar 3, 2020

most of the comments should be separate feature requests.

Which comments?
(Sorry, summarized them bit. i thought this feature may implement after many years)

  1. Please note that you will still need to click "Check for updates" when you change the local list

It's something like kill two birds with one stone 😊 (i mean instead 'edit' button)

@ghost
Copy link
Author

ghost commented Mar 3, 2020

  1. Change text on the "New blocklist/whitelist" dialogs: "Enter URL or path to the blocklist"

I think it's possible to use default filters folder too without custom paths(?)

@ameshkov
Copy link
Member

ameshkov commented Mar 3, 2020

Which comments?
(Sorry, summarized them bit. i thought this feature may implement after many years)

Well, the ones about creating a custom filter and about the filter editor that's built-in.

The original feature request sounds a little bit easier than this:)

I think it's possible to use default filters folder too without custom paths(?)

I don't think so. This folder is a part of the internal AGH configuration and it shouldn't be touched. What if at some point we will move filter lists to DB?

@ghost
Copy link
Author

ghost commented Mar 3, 2020

I don't think so. This folder is a part of the internal AGH configuration and it shouldn't be touched. What if at some point we will move filter lists to DB?

I prefer see most features configurable, customizable and maintain within web interface because it definitely easier, user friendly and development tasks may not drive on two paths or become complex when someday adguardhome available in the cloud

Something like that (not limited as NextDNS)
https://cdome.comodo.com/dome-shield
https://www.comodo.com/cdomeshield/freelicense/index.php
https://cdome.comodo.com/dns-internet-security.php
https://www.comodo.com/secure-internet-gateway.php

What if at some point we will move filter lists to DB?

Any preferred method 😊

@ghost
Copy link

ghost commented Mar 5, 2020

Looking forward to this feature :)

@szolin
Copy link
Contributor

szolin commented Mar 20, 2020

@ArtemBaskal

Change text on the "New blocklist/whitelist" dialogs: "Enter URL or path to the blocklist"

  1. UI validation:
    Absolute file path on UNIX: the path starts with /
    Absolute file path on Windows: the path starts with / or \ or [a-zA-Z]:/ or [a-zA-Z]:\

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants