Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4986 Web UI HTTP/3 not working #4993

Merged
merged 4 commits into from
Oct 10, 2022
Merged

Fix #4986 Web UI HTTP/3 not working #4993

merged 4 commits into from
Oct 10, 2022

Conversation

ssrahul96
Copy link
Contributor

@ssrahul96 ssrahul96 commented Oct 4, 2022 •
edited
Loading

Fix #4986
Even though the udp listener was listening on :443, the traffic was not sent to it, reason being the browser does not know that the website supports h3.

reference : link

So adding Alt-Svc in the header, let the browser know that http3 is enabled

After adding the header
image

h3 is used
image

@flavorgold1
Copy link

What if the port has been set to something other than 443?

@ssrahul96
Copy link
Contributor Author

443 is the standard port for https. we can get the port from config file and set, but do we really need to do it?

@ishanjain28
Copy link
Contributor

Hey @ssrahul96 Please read the port from config file. Since agh supports this, People may be accessing web ui from non-standard ports and we should try to make http3 work for every one.

@ssrahul96
Copy link
Contributor Author

@ishanjain28 @flavorgold1 , changes done to refer https port from config file

@flavorgold1
Copy link

Also, HTTP3 might be used without SSL/HTTPS.

And, AdGuardHome may reside behind a reverse-proxy that is accessing it via plain HTTP3 (non-SSL).

So, we must ensure compatibility with that scenario, unless I'm wrong about something here?

@ssrahul96
Copy link
Contributor Author

@flavorgold1 , I think SSL (TLS) is mandatory for h3

@flavorgold1
Copy link

flavorgold1 commented Oct 5, 2022 •
edited
Loading

@ssrahul96, you're right, I'm wrong.

https://www.cloudflare.com/learning/performance/what-is-http3/

It seems that SSL/TLS/encryption is required by HTTP3.

Thanks.

@Harvester57
Copy link

@ainar-g could you check this merge request please ? :)

@ghost
Copy link

ghost commented Oct 5, 2022 •
edited by ghost
Loading

I assume the port can be custom, but protocol has to be UDP? How exactly is alt-svc added to browser header? Firefox already has "network.http.http3.enable" option.

@ssrahul96
Copy link
Contributor Author

I assume the port can be custom, but protocol has to be UDP? How exactly is alt-svc added to browser header? Firefox already has "network.http.http3.enable" option.

@7ArxS2PrqAUF9Gom , network.http.http3.enable option in firefox or enable-quic flag in chrome is on the client side, so that it can use the h3 protocol,

But for the client to know that the server supports h3, Alt-Svc is set in header,

Refer the article in description for more details

@ghost
Copy link

ghost commented Oct 6, 2022 •
edited by ghost
Loading

I assume the port can be custom, but protocol has to be UDP? How exactly is alt-svc added to browser header? Firefox already has "network.http.http3.enable" option.

@7ArxS2PrqAUF9Gom , network.http.http3.enable option in firefox or enable-quic flag in chrome is on the client side, so that it can use the h3 protocol,

But for the client to know that the server supports h3, Alt-Svc is set in header,

Refer the article in description for more details

I don't understand where to place alt-svc header and how... Is it somewhere AdGuardHome.yaml? In browser? I just want to use HTTP3 for WebUI. I couldn't get any HTTP3 DoH servers to work using h3:// scheme.

@flavorgold1
Copy link

TPTB have to approve the merge request in order for this functionality to be fully active.

@ssrahul96
Copy link
Contributor Author

@7ArxS2PrqAUF9Gom , the header should be present in each and every response from AdGuard Server,

ainar-g
ainar-g requested changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@ainar-g ainar-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also document the change in CHANGELOG.md.

internal/home/control.go Outdated Show resolved Hide resolved
@ssrahul96
changes done based on review
0c0340d 
1. set only `h3` header
2. set default max-age
3. support https redirect as well
@ssrahul96
updated changelog
51f4267
@ssrahul96 ssrahul96 requested a review from ainar-g October 6, 2022 15:24
@ssrahul96
Copy link
Contributor Author

ssrahul96 commented Oct 6, 2022 •
edited
Loading

@ainar-g , will work on the fetching max-age value from config and raise a separate PR

@ainar-g
Copy link
Contributor

ainar-g commented Oct 6, 2022

@ainar-g , will work on the fetching max-age value from config and raise a separate PR

That is not necessary for now, I think. You may open a new issue about that though. We'll see if people actually need that first.

@ssrahul96
Copy link
Contributor Author

track #5011 for making max-age configurable

@ainar-g ainar-g self-assigned this Oct 10, 2022
@ainar-g ainar-g added this to the v0.107.17 milestone Oct 10, 2022
adguard pushed a commit that referenced this pull request Oct 10, 2022
@ainar-g
Pull request: 4993-alt-svc
67da002 
Updates #4986.
Updates #4993.

* commit 'd42d1a7ea48850a97f6ab74c181e4348885a4068':
  all: imp chlog; dry; fix races
  updated changelog
  changes done based on review
  referred https port from config
  added h3 header
@adguard adguard merged commit e4a42bf into AdguardTeam:master Oct 10, 2022
@ainar-g
Copy link
Contributor

ainar-g commented Oct 10, 2022

@ssrahul96, thanks for the contribution! We've made additional improvements and merged this PR.

@ssrahul96 ssrahul96 deleted the h3_alt_svc branch October 23, 2022 03:25
ssrahul96 added a commit to ssrahul96/AdGuardHome that referenced this pull request Oct 23, 2022
@ssrahul96
Squashed commit of the following:
c879845 
commit b862507
Author: Ainar Garipov <a.garipov@adguard.com>
Date:   Fri Oct 21 20:42:00 2022 +0300

    Pull request: 5035-slices-clone

    Updates AdguardTeam#5035.

    Squashed commit of the following:

    commit 9a5be90
    Author: Ainar Garipov <A.Garipov@AdGuard.COM>
    Date:   Fri Oct 21 20:11:54 2022 +0300

        all: use slices.Clone, netip.AddrPort

commit a149d81
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Fri Oct 21 20:14:43 2022 +0300

    Pull request: 4916 Editing filter

    Merge in DNS/adguard-home from 4916-fix-filter-edit to master

    Closes AdguardTeam#4916.

    Squashed commit of the following:

    commit c31be58
    Merge: c9f3e33 67d8966
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Fri Oct 21 19:58:16 2022 +0300

        Merge branch 'master' into 4916-fix-filter-edit

    commit c9f3e33
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Fri Oct 21 14:49:53 2022 +0300

        filtering: imp docs

    commit ef8228f
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Fri Oct 21 12:40:00 2022 +0300

        filtering: imp code

    commit 57fdbfc
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Thu Oct 20 11:54:39 2022 +0300

        filtering: imp docs

    commit 670ac9a
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Wed Oct 19 21:03:26 2022 +0300

        home: unexport close of clients container

    commit f5b2916
    Merge: 2e57624 2de4228
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Wed Oct 19 21:02:33 2022 +0300

        Merge branch 'master' into 4916-fix-filter-edit

    commit 2e57624
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Wed Oct 19 21:01:19 2022 +0300

        filtering: imp code, tests

    commit be56df7
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Tue Oct 18 15:31:30 2022 +0300

        filtering: fix url edit

commit 67d8966
Author: Ainar Garipov <a.garipov@adguard.com>
Date:   Fri Oct 21 19:21:21 2022 +0300

    Pull request: upd-twosky

    Merge in DNS/adguard-home from upd-twosky to master

    Squashed commit of the following:

    commit aba0225
    Author: Ainar Garipov <A.Garipov@AdGuard.COM>
    Date:   Fri Oct 21 19:13:24 2022 +0300

        all: upd twosky

commit 2a85d7d
Author: Ainar Garipov <a.garipov@adguard.com>
Date:   Fri Oct 21 14:05:10 2022 +0300

    Pull request: 3972-hostlists-registry

    Updates AdguardTeam#3972.

    Squashed commit of the following:

    commit 8341c13
    Author: Ainar Garipov <A.Garipov@AdGuard.COM>
    Date:   Fri Oct 21 13:06:55 2022 +0300

        all: imp docs

    commit b7f961c
    Merge: 607077c 68d13fc
    Author: Ainar Garipov <A.Garipov@AdGuard.COM>
    Date:   Thu Oct 20 18:23:57 2022 +0300

        Merge branch 'master' into 3972-hostlists-registry

    commit 607077c
    Author: Ainar Garipov <A.Garipov@AdGuard.COM>
    Date:   Thu Oct 20 18:07:09 2022 +0300

        all: use hostlists registry

commit 68d13fc
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Thu Oct 20 18:22:37 2022 +0300

    Pull request: 5052 Close errors

    Merge in DNS/adguard-home from 5052-nonfatal-close to master

    Updates AdguardTeam#5052.

    Squashed commit of the following:

    commit 8411de4
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Thu Oct 20 16:54:52 2022 +0300

        dnsforward: imp code

    commit d6dff96
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Thu Oct 20 16:48:55 2022 +0300

        dnsforward: revert tmp stuff

    commit 519aaf2
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Thu Oct 20 16:28:32 2022 +0300

        dnsforward: fix ups closing errors

commit 2de4228
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Wed Oct 19 16:13:05 2022 +0300

    Pull request: 5044 Close upstreams

    Merge in DNS/adguard-home from 5044-close-upstreams to master

    Closes AdguardTeam#5044.

    Squashed commit of the following:

    commit e121380
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Wed Oct 19 15:54:17 2022 +0300

        all: upd proxy again

    commit ce7fa53
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Wed Oct 19 14:30:46 2022 +0300

        home: imp docs, names

    commit 851c5b8
    Merge: b9ee5d6 d2a09e4
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Wed Oct 19 14:21:44 2022 +0300

        Merge branch 'master' into 5044-close-upstreams

    commit b9ee5d6
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Wed Oct 19 14:20:15 2022 +0300

        all: close upstreams more

    commit eaca476
    Merge: f924bc7 8dba4ec
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Tue Oct 18 18:33:53 2022 +0300

        Merge branch 'master' into 5044-close-upstreams

    commit f924bc7
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Tue Oct 18 18:23:54 2022 +0300

        all: imp code, docs

    commit 011fde1
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Tue Oct 18 17:26:40 2022 +0300

        all: upd dnsproxy

commit d2a09e4
Author: Ainar Garipov <a.garipov@adguard.com>
Date:   Wed Oct 19 13:18:34 2022 +0300

    Pull request: upd-i18n

    Merge in DNS/adguard-home from upd-i18n to master

    Squashed commit of the following:

    commit 9c7c24b
    Author: Ainar Garipov <A.Garipov@AdGuard.COM>
    Date:   Wed Oct 19 13:02:18 2022 +0300

        client: imp sr-cs

    commit 7daa7db
    Author: Ainar Garipov <A.Garipov@AdGuard.COM>
    Date:   Wed Oct 19 12:40:37 2022 +0300

        client: upd i18n

commit e0080ff
Author: Ainar Garipov <a.garipov@adguard.com>
Date:   Wed Oct 19 12:13:22 2022 +0300

    Pull request: upd-companiesdb

    Merge in DNS/adguard-home from upd-companiesdb to master

    Squashed commit of the following:

    commit c38ccd8
    Author: Ainar Garipov <A.Garipov@AdGuard.COM>
    Date:   Wed Oct 19 12:00:58 2022 +0300

        client: upd trackers

commit 8dba4ec
Author: Ainar Garipov <a.garipov@adguard.com>
Date:   Tue Oct 18 17:45:04 2022 +0300

    Pull request: cve-id

    Merge in DNS/adguard-home from cve-id to master

    Squashed commit of the following:

    commit 5a5418d
    Author: Ainar Garipov <A.Garipov@AdGuard.COM>
    Date:   Tue Oct 18 17:28:49 2022 +0300

        all: upd cve id

commit aaaa56f
Merge: fee81b3 ab79168
Author: Ainar Garipov <a.garipov@adguard.com>
Date:   Fri Oct 14 20:44:29 2022 +0300

    Pull request: 4990-custom-ciphers

    Updates AdguardTeam#4925.
    Updates AdguardTeam#4990.

    * commit 'ab79168b13a5680557147de098c740bca974392e':
      all: fix chlog
      home: refactor override
      updated changelog
      fixed formatting
      changed based on review
      changes done as per review comments
      added ciphers for h3
      Pull request: imp-scripts
      Pull request: imp-stalebot
      spelling corrected UserPreferredCipherSuites
      added support for User prefered Ciphers
      Revert "adding TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA to safe cipher suite"
      adding TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA to safe cipher suite

commit ab79168
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri Oct 14 20:19:25 2022 +0300

    all: fix chlog

commit 5ae826d
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri Oct 14 20:14:07 2022 +0300

    home: refactor override

commit a736f67
Merge: a126f51 fee81b3
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Fri Oct 14 19:41:43 2022 +0300

    Merge branch 'master' into 4990-custom-ciphers

commit fee81b3
Author: Ainar Garipov <a.garipov@adguard.com>
Date:   Fri Oct 14 19:37:14 2022 +0300

    Pull request: 4925-refactor-tls-vol-2

    Updates AdguardTeam#4925.

    Squashed commit of the following:

    commit 4b22193
    Author: Ainar Garipov <A.Garipov@AdGuard.COM>
    Date:   Fri Oct 14 19:03:42 2022 +0300

        all: refactor tls

commit a1acfbb
Author: Ainar Garipov <a.garipov@adguard.com>
Date:   Fri Oct 14 19:03:03 2022 +0300

    Pull request: 4925-refactor-tls-vol-1

    Merge in DNS/adguard-home from 4925-refactor-tls-vol-1 to master

    Squashed commit of the following:

    commit ad87b2e
    Author: Ainar Garipov <A.Garipov@AdGuard.COM>
    Date:   Fri Oct 14 18:49:22 2022 +0300

        all: refactor tls, vol. 1

        Co-Authored-By: Rahul Somasundaram <Rahul.Somasundaram@checkpt.com>

commit 4582b1c
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Fri Oct 14 15:29:44 2022 +0300

    Pull request: Migrate to netip.Addr vol.1

    Merge in DNS/adguard-home from 2926-lla-v6 to master

    Updates AdguardTeam#2926.
    Updates AdguardTeam#5035.

    Squashed commit of the following:

    commit 2e770d4
    Merge: 25c1afc 893358e
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Fri Oct 14 15:14:56 2022 +0300

        Merge branch 'master' into 2926-lla-v6

    commit 25c1afc
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Thu Oct 13 18:24:20 2022 +0300

        all: imp code, docs

    commit 59549c4
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Tue Oct 11 18:49:09 2022 +0300

        dhcpd: use netip initially

    commit 1af6230
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Fri Sep 30 18:03:52 2022 +0300

        all: imp docs, code

    commit e9faeb7
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Thu Sep 29 14:56:37 2022 +0300

        all: use netip for web

    commit 38305e5
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Wed Sep 28 19:13:58 2022 +0300

        add basic lla

commit 893358e
Author: Ainar Garipov <a.garipov@adguard.com>
Date:   Thu Oct 13 18:27:20 2022 +0300

    Pull request: 5023-readme-debug

    Closes AdguardTeam#5023.

    Squashed commit of the following:

    commit d6e8412
    Author: Ainar Garipov <A.Garipov@AdGuard.COM>
    Date:   Thu Oct 13 17:56:59 2022 +0300

        all: fix align

    commit 28b1ac3
    Author: Ainar Garipov <A.Garipov@AdGuard.COM>
    Date:   Thu Oct 13 17:43:18 2022 +0300

        all: fix more links

    commit 29d7ad4
    Author: Ainar Garipov <A.Garipov@AdGuard.COM>
    Date:   Thu Oct 13 17:41:46 2022 +0300

        all: imp readme, fix links

    commit f75438d
    Author: Ainar Garipov <A.Garipov@AdGuard.COM>
    Date:   Thu Oct 13 16:50:02 2022 +0300

        all: imp readme

commit f109fb1
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Oct 11 19:49:35 2022 +0300

    Pull request: 5010 revert default cache size

    Merge in DNS/adguard-home from 5010-default-settings to master

    Updates AdguardTeam#5010.

    Squashed commit of the following:

    commit 19edb2c
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Tue Oct 11 19:45:49 2022 +0300

        all: imp log of changes

    commit a0ad92f
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Tue Oct 11 19:34:37 2022 +0300

        home: revert default value

commit 5604e33
Author: Eugene Burkov <e.burkov@adguard.com>
Date:   Tue Oct 11 15:58:02 2022 +0300

    Pull request: 4942 cache poisoning

    Merge in DNS/adguard-home from 4942-cache-poisoning to master

    Updates AdguardTeam#4942.

    Squashed commit of the following:

    commit aec2ccd
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Tue Oct 11 15:41:18 2022 +0300

        all: imp wording

    commit dba35a1
    Author: Eugene Burkov <E.Burkov@AdGuard.COM>
    Date:   Tue Oct 11 15:13:35 2022 +0300

        all: upd proxy

commit 67da002
Merge: 0eba31c d42d1a7
Author: Ainar Garipov <a.garipov@adguard.com>
Date:   Mon Oct 10 18:42:53 2022 +0300

    Pull request: 4993-alt-svc

    Updates AdguardTeam#4986.
    Updates AdguardTeam#4993.

    * commit 'd42d1a7ea48850a97f6ab74c181e4348885a4068':
      all: imp chlog; dry; fix races
      updated changelog
      changes done based on review
      referred https port from config
      added h3 header

commit d42d1a7
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Oct 10 18:34:53 2022 +0300

    all: imp chlog; dry; fix races

commit e4a42bf
Merge: 51f4267 0eba31c
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Mon Oct 10 17:59:12 2022 +0300

    Merge branch 'master' into 4993-alt-svc

commit 0eba31c
Author: Ildar Kamalov <ik@adguard.com>
Date:   Mon Oct 10 17:49:19 2022 +0300

    Pull request: 4815 fix table view of the query log modal

    Updates AdguardTeam#4815

    Squashed commit of the following:

    commit a547c54
    Merge: 3c1e745 f5602d9
    Author: Ildar Kamalov <ik@adguard.com>
    Date:   Mon Oct 10 17:40:38 2022 +0300

        Merge branch 'master' into 4815-tablet-view-fix

    commit 3c1e745
    Author: Ildar Kamalov <ik@adguard.com>
    Date:   Mon Oct 10 16:50:10 2022 +0300

        fix mobile view

    commit a1d0b36
    Author: Ildar Kamalov <ik@adguard.com>
    Date:   Sun Oct 9 17:57:14 2022 +0300

        client: fix styles

    commit f34f928
    Author: Ildar Kamalov <ik@adguard.com>
    Date:   Sun Oct 9 16:59:23 2022 +0300

        client: fix table view of query log modal

commit f5602d9
Author: Ainar Garipov <a.garipov@adguard.com>
Date:   Mon Oct 10 14:05:24 2022 +0300

    Pull request: hup-reload

    Merge in DNS/adguard-home from hup-reload to master

    Squashed commit of the following:

    commit 5cd4ab8
    Author: Ainar Garipov <A.Garipov@AdGuard.COM>
    Date:   Fri Oct 7 19:58:17 2022 +0300

        next: imp signal hdlr

    commit 8fd18e7
    Merge: a878045 f1dd333
    Author: Ainar Garipov <A.Garipov@AdGuard.COM>
    Date:   Fri Oct 7 19:46:48 2022 +0300

        Merge branch 'master' into hup-reload

    commit a878045
    Merge: 349dbe5 960a7a7
    Author: Ainar Garipov <A.Garipov@AdGuard.COM>
    Date:   Fri Oct 7 15:49:23 2022 +0300

        Merge branch 'master' into hup-reload

    commit 349dbe5
    Author: Ainar Garipov <A.Garipov@AdGuard.COM>
    Date:   Fri Oct 7 15:43:52 2022 +0300

        next: imp docs, names

    commit 7287a86
    Author: Ainar Garipov <A.Garipov@AdGuard.COM>
    Date:   Fri Oct 7 13:39:44 2022 +0300

        WIP all: impl dynamic reconfiguration

commit f1dd333
Author: Ainar Garipov <a.garipov@adguard.com>
Date:   Fri Oct 7 17:05:01 2022 +0300

    Pull request: upd-chlog

    Merge in DNS/adguard-home from upd-chlog to master

    Squashed commit of the following:

    commit 8885f3f
    Author: Ainar Garipov <A.Garipov@AdGuard.COM>
    Date:   Fri Oct 7 16:56:38 2022 +0300

        all: upd chlog

commit 960a7a7
Author: Ainar Garipov <a.garipov@adguard.com>
Date:   Fri Oct 7 15:48:51 2022 +0300

    Pull request: upd-go

    Merge in DNS/adguard-home from upd-go to master

    Squashed commit of the following:

    commit 3dffc8b
    Author: Ainar Garipov <A.Garipov@AdGuard.COM>
    Date:   Fri Oct 7 14:30:23 2022 +0300

        all: fix chlog

    commit cca70bd
    Author: Ainar Garipov <A.Garipov@AdGuard.COM>
    Date:   Fri Oct 7 14:07:39 2022 +0300

        all: upd go

commit a126f51
Author: Rahul Somasundaram <Rahul.Somasundaram@checkpt.com>
Date:   Thu Oct 6 21:48:22 2022 +0530

    updated changelog

commit c0c9d8a
Author: Rahul Somasundaram <Rahul.Somasundaram@checkpt.com>
Date:   Thu Oct 6 21:44:43 2022 +0530

    fixed formatting

commit 7cac010
Author: Rahul Somasundaram <Rahul.Somasundaram@checkpt.com>
Date:   Thu Oct 6 21:37:15 2022 +0530

    changed based on review

    1. exit AG is user defined cipher is invalid
    2. updated changelog
    3. golang naming tweaks

commit 51f4267
Author: Rahul Somasundaram <Rahul.Somasundaram@checkpt.com>
Date:   Thu Oct 6 20:53:23 2022 +0530

    updated changelog

commit 0c0340d
Author: Rahul Somasundaram <Rahul.Somasundaram@checkpt.com>
Date:   Thu Oct 6 20:44:55 2022 +0530

    changes done based on review

    1. set only `h3` header
    2. set default max-age
    3. support https redirect as well

commit b7e8154
Author: Rahul Somasundaram <Rahul.Somasundaram@checkpt.com>
Date:   Wed Oct 5 18:27:01 2022 +0530

    referred https port from config

commit 15b19ff
Author: Rahul Somasundaram <ssrahul96@gmail.com>
Date:   Wed Oct 5 00:12:53 2022 +0530

    changes done as per review comments

commit 6a62f70
Author: Rahul Somasundaram <Rahul.Somasundaram@checkpt.com>
Date:   Tue Oct 4 11:01:21 2022 +0530

    added h3 header

commit 24eb347
Author: Rahul Somasundaram <Rahul.Somasundaram@checkpt.com>
Date:   Tue Oct 4 09:51:55 2022 +0530

    added ciphers for h3

commit 8a924cb
Merge: bf792b8 6e7964c
Author: Rahul Somasundaram <Rahul.Somasundaram@checkpt.com>
Date:   Tue Oct 4 08:38:51 2022 +0530

    fixed conflict

commit 6e7964c
Author: Ainar Garipov <a.garipov@adguard.com>
Date:   Wed Sep 21 19:21:13 2022 +0300

    Pull request: imp-scripts

    Merge in DNS/adguard-home from imp-scripts to master

    Squashed commit of the following:

    commit ab63a8a
    Author: Ainar Garipov <A.Garipov@AdGuard.COM>
    Date:   Wed Sep 21 19:15:06 2022 +0300

        all: imp scripts; upd tools; doc

commit 9d59be4
Author: Ainar Garipov <a.garipov@adguard.com>
Date:   Wed Sep 21 15:02:35 2022 +0300

    Pull request: imp-stalebot

    Merge in DNS/adguard-home from imp-stalebot to master

    Squashed commit of the following:

    commit d1fb5c6
    Author: Ainar Garipov <A.Garipov@AdGuard.COM>
    Date:   Wed Sep 21 14:31:50 2022 +0300

        all: imp stalebot

commit 690deb1
Author: Rahul Somasundaram <Rahul.Somasundaram@checkpt.com>
Date:   Thu Sep 22 08:44:43 2022 +0530

    spelling corrected UserPreferredCipherSuites

commit 59d18c6
Author: Rahul Somasundaram <Rahul.Somasundaram@checkpt.com>
Date:   Thu Sep 22 08:28:46 2022 +0530

    added support for User prefered Ciphers

commit 91bbb74
Author: Rahul Somasundaram <Rahul.Somasundaram@checkpt.com>
Date:   Thu Sep 22 07:53:39 2022 +0530

    Revert "adding TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA to safe cipher suite"

    This reverts commit fe0c53e.

commit fe0c53e
Author: Rahul Somasundaram <Rahul.Somasundaram@checkpt.com>
Date:   Tue Sep 20 21:16:52 2022 +0530

    adding TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA to safe cipher suite
@ainar-g ainar-g modified the milestones: v0.107.18, v0.107.17 Nov 2, 2022
@ghost
Copy link

ghost commented Feb 20, 2023 •
edited by ghost
Loading

I still don't understand this... I enable HTTPS/3 in Firefox and test that it works on sites like YouTube by pressing F12 and viewing Network tab. HTTPS/3 works on YouTube just fine, firewall shows UDP port 443 connections, but HTTPS/3 doesn't work when I try to login to AdGuard Home UI. AdGuard Home just uses HTTPS/2 over TCP port 443. IPTables on Raspberry Pi do not show any attempts from my machine to use HTTPS/3 UDP port 443 when accessing AdGuard Home UI.

In AdGuardHome.yaml file I see "serve_http3: true". What else am I supposed to do? I don't understand where to edit the Alt-Header information...? In AdGuardHome.yaml file? In Firefox URL? Is it not possible to have a URL for UDP port 443? I realize that is what Alt-Svc is for, but it is enabled in Firefox and Firefox does use HTTPS/3 on sites that support it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ainar-g ainar-g Awaiting requested review from ainar-g

Assignees

@ainar-g ainar-g

Labels
bug P3: Medium
Projects
None yet
Milestone
v0.107.17
Development

Successfully merging this pull request may close these issues.

Web UI HTTP/3 not working
6 participants
@ssrahul96 @flavorgold1 @ishanjain28 @Harvester57 @ainar-g @adguard