Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add amazon.com.be to the filter list. #5108

Closed
wants to merge 1 commit into from
Closed

Add amazon.com.be to the filter list. #5108

wants to merge 1 commit into from

Conversation

fernvenue
Copy link
Contributor

@codecov-commenter
Copy link

Codecov Report

Base: 45.51% // Head: 45.37% // Decreases project coverage by -0.13% ⚠️

Coverage data is based on head (04d9b36) compared to base (a7d02fa).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    AdguardTeam/AdGuardHome#5108      +/-   ##
==========================================
- Coverage   45.51%   45.37%   -0.14%     
==========================================
  Files         116      116              
  Lines       12482    12482              
==========================================
- Hits         5681     5664      -17     
- Misses       6201     6224      +23     
+ Partials      600      594       -6     
Impacted Files Coverage Δ
internal/stats/stats.go 52.77% <0.00%> (-5.10%) ⬇️
internal/stats/unit.go 68.38% <0.00%> (-3.88%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ainar-g
Copy link
Contributor

ainar-g commented Nov 8, 2022

Thank you for the contribution, but please see the comment on top of servicelist.go as well as #3972. You can open pretty much the same PR in the Hostlists Registry repo and add the rule to assets/services.json, and it should land in AdGuard Home with the next update.

@ainar-g ainar-g closed this Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants