Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct schema type for client upstreams_cache_size #6564

Merged
merged 1 commit into from
Dec 20, 2023
Merged

correct schema type for client upstreams_cache_size #6564

merged 1 commit into from
Dec 20, 2023

Conversation

bakito
Copy link
Contributor

@bakito bakito commented Dec 20, 2023

The openapi schema has a wrong data type for the Client field upstreams_cache_size.

Currently in the schema it is defined as boolean, but in the struct an integer.

Signed-off-by: bakito <github@bakito.ch>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0920bb9) 51.72% compared to head (8d1e1e8) 51.72%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6564   +/-   ##
=======================================
  Coverage   51.72%   51.72%           
=======================================
  Files         179      179           
  Lines       14603    14603           
=======================================
  Hits         7553     7553           
  Misses       6313     6313           
  Partials      737      737           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ainar-g ainar-g self-assigned this Dec 20, 2023
@ainar-g ainar-g added this to the v0.107.44 milestone Dec 20, 2023
@ainar-g
Copy link
Contributor

ainar-g commented Dec 20, 2023

Thank you for your contribution! We'll review it shortly.

@adguard adguard merged commit 8d1e1e8 into AdguardTeam:master Dec 20, 2023
8 checks passed
adguard pushed a commit that referenced this pull request Dec 20, 2023
Updates #6564.

* commit '9bfad46a6ca813fe1d6e50b7039476351f2c68c6':
  openapi: upd chlog
  correct schema type for client upstreams_cache_size
@ainar-g ainar-g modified the milestones: v0.107.45, v0.107.44 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants