Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selector lib creates an invalid rule #133

Closed
ameshkov opened this issue Jan 18, 2016 · 1 comment
Closed

Selector lib creates an invalid rule #133

ameshkov opened this issue Jan 18, 2016 · 1 comment
Assignees
@Mizzick
Labels
Bug
Milestone
2.2

Comments

@ameshkov
Copy link
Member

Steps to reproduce:

  1. Open "bild.de"
  2. Scroll down and try to block "Tweets aus der Redaktion" element:
    http://screencast.com/t/3DA2hmOuufZ
  3. You'll see that selector created by us is invalid:
    bild.de###innerWrapper > DIV.faux.clearfix:nth-child(10) > DIV.content.s15 > SECTION > DIV > DIV.pagination:last-child > DIV.module.tlx > DIV.tlw-15.clearfix > DIV.misc..posLast > DIV.pm-hot-bei-bild:last-child > UL > LI:last-child

The problem is in two dots: DIV.misc**..**posLast
@ameshkov ameshkov added the Bug label Jan 18, 2016
@ameshkov ameshkov added this to the 2.2 milestone Jan 18, 2016
@ameshkov ameshkov changed the title Selector lib creates invalid rule Selector lib creates an invalid rule Jan 18, 2016
Mizzick added a commit that referenced this issue Feb 18, 2016
@Mizzick
#133 fix
4a8be06
@Mizzick
Copy link
Contributor

Mizzick commented Feb 18, 2016

Fixed

@Mizzick Mizzick closed this as completed Feb 18, 2016
Mizzick added a commit that referenced this issue Feb 18, 2016
@Mizzick
#133 fix
c33ac04
ameshkov added a commit that referenced this issue Dec 28, 2018
@ameshkov
Merge pull request #133 in EXTENSIONS/browser-extension from feature/…
93b992e 
…issues/1008 to feature/redesign

* commit 'ca49719a90b72b381f4aa55efd0a5c5c58897662':
  #1008 popup statuses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mizzick Mizzick

Labels
Bug
Projects
None yet
Milestone
2.2
Development

No branches or pull requests
2 participants
@ameshkov @Mizzick