Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chrome] "Block ads on this site" button doesn't work if few windows are opened #134

Closed
gshumihin opened this issue Jan 19, 2016 · 3 comments
Closed

[chrome] "Block ads on this site" button doesn't work if few windows are opened #134

gshumihin opened this issue Jan 19, 2016 · 3 comments
Assignees
@Mizzick
Labels
Bug Chromium
Milestone
2.2

Comments

@gshumihin
Copy link

Steps to reproduce:

  1. Open at least two chrome windows
  2. Install in one of them adguard extension
  3. Tab to second one
  4. Try to block something with button "Block ads on this site"
@gshumihin gshumihin added the Bug label Jan 19, 2016
@gshumihin gshumihin assigned ameshkov and Mizzick and unassigned ameshkov Jan 19, 2016
@ameshkov ameshkov added this to the 2.2 milestone Jan 20, 2016
@atropnikov atropnikov changed the title [chorme] "Block ads on this site" button doesn't work if few windows are opened [chrome] "Block ads on this site" button doesn't work if few windows are opened Jan 21, 2016
Mizzick added a commit that referenced this issue Feb 17, 2016
@Mizzick
#134 lastFocusedWindow
d6095c0
@Mizzick
Copy link
Contributor

Mizzick commented Feb 17, 2016

https://code.google.com/p/chromium/issues/detail?id=546696&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Cr%20Status%20Owner%20Summary%20OS%20Modified&start=100

There is a possible bug in chrome with
chrome.windows.getLastFocused()

@Mizzick Mizzick closed this as completed Feb 17, 2016
@ameshkov
Copy link
Member

Nice, so it's all good now?

@Mizzick
Copy link
Contributor

Mizzick commented Feb 21, 2016

Yeap, check the #167

ameshkov added a commit that referenced this issue Feb 23, 2016
@ameshkov
Merge pull request #167 from AdguardTeam/feature/issues/134
55af551 
#134 las…
maximtop added a commit that referenced this issue Aug 10, 2018
@maximtop
Merge pull request #134 in EXTENSIONS/browser-extension from feature/…
cefa1ab 
…issues/1010 to master

* commit '140b1502cfb41a1a74e7b1a2609796acb414d026':
  fix readme comment
  remove unesed punicode library from file
  combine public suffix download with filters download
  set option skipBinary to true, because images become broken without it
  add new task for public suffix list update and method to update RESERVED_DOMAINS variable for builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mizzick Mizzick

Labels
Bug Chromium
Projects
None yet
Milestone
2.2
Development

No branches or pull requests
3 participants
@ameshkov @gshumihin @Mizzick