Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XMLDocument can be a valid HTML document #233

Closed
ameshkov opened this issue Apr 20, 2016 · 1 comment
Closed

XMLDocument can be a valid HTML document #233

ameshkov opened this issue Apr 20, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@ameshkov
Copy link
Member

ameshkov commented Apr 20, 2016

Ads are not blocked on seclub.org
https://seclub.org/dn.php?d=4&r=6

For some reason this check does not work on this website:

        if (!(document instanceof HTMLDocument)) {
            return;
        }

document is XMLDocument there.

Use this instead:

var isHtml = function() { 
    return (document instanceof HTMLDocument) ||
        // https://github.com/AdguardTeam/AdguardBrowserExtension/issues/233
        ((document instanceof XMLDocument) && (document.createElement('div') instanceof HTMLDivElement)); 
};
@ameshkov ameshkov added the Bug label Apr 20, 2016
@ameshkov ameshkov added this to the 2.3 milestone Apr 20, 2016
Mizzick added a commit that referenced this issue Apr 21, 2016
@Mizzick
Copy link
Contributor

Mizzick commented Apr 21, 2016

Fixed

@Mizzick Mizzick closed this as completed Apr 21, 2016
ameshkov pushed a commit that referenced this issue Dec 28, 2018
…redesign-merge to feature/redesign

* commit '810f23ff604bd37084140ca1343599023cb3402e': (64 commits)
  fix preserve log button
  remove jquery file, replace tabs with spaces
  fix preserve log style
  remove unnecessary conditionals
  replace other versions from popup footer with copyright
  show only ios and android in the footer
  udpate readme for v2.10.11
  update resources
  update version
  update locales
  update readme
  update translations
  update version to 2.10.10
  update filters
  fix comment
  do not override edge websocket requests
  update jquery from 2.2.4 to 3.3.1
  on update local script rules push only unique rules
  fix test error
  update resources
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants