Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] When selected checkboxes Blocked and Whitelist the log should display Blocked+Whitelisted requests #35

Closed
Alex-302 opened this issue Oct 20, 2015 · 6 comments

Comments

@Alex-302
Copy link
Member

No description provided.

@Mizzick
Copy link
Contributor

Mizzick commented Mar 4, 2016

Ok, and what it displays now for Blocked+Whitelisted?

What do you mean under Blocked+Whitelisted?
I see two possible options: "Blocked OR Whitelisted" or "Blocked AND Whitelisted". The "AND" option seems to be more correct in this case.

@Alex-302
Copy link
Member Author

Alex-302 commented Mar 4, 2016

Now if selected Blocked and Whitelisted, the list is empty.

I mean "Blocked AND Whitelisted". Sometimes it is useful to see only blocked and whitelisted simultaneously.

@ameshkov
Copy link
Member

ameshkov commented Mar 5, 2016

@Mizzick why so?

You would be right if we had radio buttons there.
But checkboxes group usually means OR, not AND.

@Mizzick
Copy link
Contributor

Mizzick commented Mar 8, 2016

Actually I think checkboxes list in filters means AND. But in our case it seems to be more possible an UI mistake.
I will show you something:
show &= !this.searchWhitelisted || (filterData.requestRule && filterData.requestRule.whiteListRule);
show &= !this.searchBlocked || (filterData.requestRule && !filterData.requestRule.whiteListRule);

So Blocked OR Whitelisted will just show all items.

@ameshkov
Copy link
Member

ameshkov commented Mar 9, 2016

Actually I think checkboxes list in filters means AND.

That's what we are talking about. Currently checkboxes means AND, but by UX guidelines checkboxes should mean OR.

So Blocked OR Whitelisted will just show all items.

It is really not that hard to make it work properly instead.

Mizzick added a commit that referenced this issue Mar 9, 2016
@Mizzick
Copy link
Contributor

Mizzick commented Mar 9, 2016

Fixed

@Mizzick Mizzick closed this as completed Mar 9, 2016
@Mizzick Mizzick added this to the 2.3 milestone Mar 9, 2016
Mizzick added a commit that referenced this issue Apr 12, 2016
Mizzick added a commit that referenced this issue Apr 12, 2016
ameshkov pushed a commit that referenced this issue Oct 3, 2017
…uild/2.7.2 to master

* commit '2a6694cfbdc245b3123438fd60ba9b2f10a40f92':
  updated filters
  Fixed Edge manifest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants