Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube.com: URL tracking #142820

Closed
6 tasks done
MasterKia opened this issue Feb 13, 2023 · 9 comments
Closed
6 tasks done

youtube.com: URL tracking #142820

MasterKia opened this issue Feb 13, 2023 · 9 comments
Assignees
Labels
A: In progress Work on the issue is in progress T: Analytics Collecting analytics and tracking users

Comments

@MasterKia
Copy link
Contributor

MasterKia commented Feb 13, 2023

Prerequisites

  • This site DOES NOT contains sexually explicit material, otherwise use NSFW-specific form;
  • Filters were updated before reproducing an issue;
  • AdGuard product version is up-to-date;
  • Browser version is up-to-date;
  • If the site or app is broken, disabling AdGuard protection resolves an issue.

What product do you use?

Other ad blocker

AdGuard version

.

What type of problem have you encountered?

Missed analytics or tracker

Which browser(s) do you use?

Firefox

Which device do you use?

Desktop

Where is the problem encountered?

https://www.youtube.com/watch?v=pAZWv8QQ8Co

What filters do you have enabled?

AdGuard URL Tracking filter

What Stealth Mode options do you have enabled?

No response

Add your comment and screenshots

YouTube's description links have tracking parameters.

Example:
https://www.youtube.com/watch?v=pAZWv8QQ8Co

In the description:
https://www.youtube.com/redirect?event=video_description&redir_token=[...]&q=https%3A%2F%2Fwww.paypal.me%2Fpaysyfr&v=pAZWv8QQ8Co

event, redir_token, q being the destination link and v being the video id.

Proposed filters for AdGuard URL Tracking Protection:

||youtube.com/redirect?$removeparam=event
||youtube.com/redirect?$removeparam=redir_token
||youtube.com/redirect?$removeparam=v

Result link:
https://www.youtube.com/redirect?q=https%3A%2F%2Fwww.paypal.me%2Fpaysyfr

Privacy

  • I agree to follow this condition
@krystian3w
Copy link
Contributor

Maybe good for only My Filters Tab or User Rules (.../pages/options.html#user-filter) tab/Filter (apps may have list named as Filter - similar to legacy interface of ABP) due links will always ask to confirm redirect.

@MasterKia
Copy link
Contributor Author

links will always ask to confirm redirect.

It's better than YouTube tracking which external links the user has clicked on (v parameter for video id).

@krystian3w
Copy link
Contributor

krystian3w commented Feb 14, 2023

Worse if every day people start complaining and "you" have to paste them a link to the solution:

  • disable Filter "URL tracking"
    or
  • add this to AdGuard's own rules / my filters in uBO:
    ||youtube.com/redirect?$removeparam=event,badfilter
    ||youtube.com/redirect?$removeparam=redir_token,badfilter
    ||youtube.com/redirect?$removeparam=v,badfilter

These clicker can be used in scams:

[path="/redirect?q="]www.youtube.com#%#//scriptlet('trusted-click-element', '#invalid-token-redirect-goto-site-button', '', '500')

@MasterKia
Copy link
Contributor Author

[path="/redirect?q="]www.youtube.com#%#//scriptlet('trusted-click-element', '#invalid-token-redirect-goto-site-button', '', '500')

Trusted filters are only controlled by the AdGuard team or My filters or user trusted filterlists.

@krystian3w
Copy link
Contributor

krystian3w commented Feb 14, 2023

But for a while the link will be automatically clicked in someone.

Maintaining in regex a list of domains where clicking looks OK may not be possible (especially when the line exceeds the limit of allowed characters per filter rule e.g. 65 kilibytes).

@AdamWr
Copy link
Member

AdamWr commented Feb 14, 2023

I'm not sure if these rules should be added as it causes that there is necessary to confirm redirection.
There was issue about confirming redirection (caused by $cookie rule) here - #128041 (comment) and related comment - #128041 (comment) (and comments below).
So I guess that it's not user friendly and there will be similar reports.

@Alex-302 Could you please take a look at this issue when you come back from vacation?

@AdamWr AdamWr added T: Analytics Collecting analytics and tracking users A: In progress Work on the issue is in progress and removed Unsorted labels Feb 14, 2023
@Alex-302
Copy link
Member

I'm not sure if these rules should be added as it causes that there is necessary to confirm redirection.

This is annoying behavior. The rule is for user filter only.

@MasterKia
Copy link
Contributor Author

So AdGuard doesn't block any click-tracker links too just in case some users get upset? So much for "AdGuard Tracking protection" list.

@Alex-302
Copy link
Member

You will be tracked by Google in any case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: In progress Work on the issue is in progress T: Analytics Collecting analytics and tracking users
Projects
None yet
Development

No branches or pull requests

4 participants