Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #196940 cyberinsider.com #196941

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Conversation

xglossyntx
Copy link
Contributor

Creating the pull request

Please include a summary of the change and which issue is fixed
If the related issue does not exist in our repository, please create it before making pull request
It is highly recommended to use our Web Reporting Tool instead of creating an issue on GitHub directly
Please note, that we verify every pull request manually, so it may take time to apply it

Prerequisites

To avoid invalid pull requests, please check and confirm following terms

  • This is not an ad/bug report;
  • My code follows the guidelines and syntax of this project;
  • I have performed a self-review of my own changes;
  • My changes do not break web sites, apps and files structure.

What problem does the pull request fix?

If the problem does not fall under any category that is listed here, please write a comment below in corresponding section

  • Missed ads or ad leftovers;
  • Website or app doesn't work properly;
  • AdGuard gets detected on a website;
  • Missed analytics or tracker;
  • Social media buttons — share, like, tweet, etc;
  • Annoyances — pop-ups, cookie warnings, etc;
  • Filters maintenance.

What issue is being fixed?

Enter the issue address

Fix #196940

Terms

  • By submitting this issue, I agree that pull request does not contain private info and all conditions are met

@zloyden zloyden added the A: In progress Work on the issue is in progress label Jan 23, 2025
@xglossyntx
Copy link
Contributor Author

xglossyntx commented Jan 23, 2025

I could merge this with my other rule ||cb9825.wbur.org/app/js/api.min.js by doing /app/js/api.min.js$domain=cyberinsider.com|wbur.org, if you'd like.

@xglossyntx
Copy link
Contributor Author

xglossyntx commented Jan 23, 2025

||cb9825.wbur.org/app/js/api.min.js is in subscriptions_specific, so I was not sure if it would be alright to merge them. If not, we can just keep it as is.

@zloyden
Copy link
Contributor

zloyden commented Jan 23, 2025

I could merge this with my other rule ||cb9825.wbur.org/app/js/api.min.js by doing /app/js/api.min.js$domain=cyberinsider.com|wbur.org, if you'd like.

Could you do that?

subscriptions_specific

I was just writing about it. I guess self-promo.txt is ok for this. Please move the rule there.

@xglossyntx
Copy link
Contributor Author

xglossyntx commented Jan 23, 2025

I could merge this with my other rule ||cb9825.wbur.org/app/js/api.min.js by doing /app/js/api.min.js$domain=cyberinsider.com|wbur.org, if you'd like.

Could you do that?

subscriptions_specific

I was just writing about it. I guess self-promo.txt is ok for this. Please move the rule there.

"! Self-promo example: promoting other services from the same company (if it's annoying enough)."

Does cyberinsider.com own NordVPN? If so, do they also own ProtonMail?
https://cyberinsider.com/email/best-encrypted-email/

Screenshot 1

image

@zloyden
Copy link
Contributor

zloyden commented Jan 23, 2025

Do those links lead to third-party sites? If so, you can move it to Base filter.
For some reason, the popup do not appear now, so can't check it, but the rule worked fine on my end.

@zloyden zloyden removed the A: In progress Work on the issue is in progress label Jan 23, 2025
@xglossyntx
Copy link
Contributor Author

Do those links lead to third-party sites? If so, you can move it to Base filter.

The ProtonMail one goes to https://cyberinsider.com/go/protonmail, which then redirects to https://proton.me/l/mail-plans?url_id=832.

@zloyden
Copy link
Contributor

zloyden commented Jan 23, 2025

The ProtonMail one goes to cyberinsider.com/go/protonmail, which then redirects to proton.me/l/mail-plans?url_id=832.

Got it. Please move it to AdGuard Base - specific.txt.

@xglossyntx xglossyntx requested a review from zloyden January 23, 2025 15:15
@zloyden zloyden merged commit 41ffbfe into AdguardTeam:master Jan 23, 2025
2 checks passed
@xglossyntx xglossyntx deleted the Fix-cyberinsider.com branch January 23, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cyberinsider.com
3 participants