Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new regex filter to cover another class of revolving adservers #84613

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

Yuki2718
Copy link
Collaborator

@Yuki2718 Yuki2718 commented Jun 1, 2021

easylist/easylist#6476
https://regex101.com/r/1g9Jh6/1
Once mentioned in Slack, then FP reported in uBlockOrigin/uAssets#8280 so improved with $match-case. So far no FP report in this version and I think it's worth being added to AG too.

@Alex-302
Copy link
Member

Alex-302 commented Jun 1, 2021

@Yuki2718 Could you please show full URLs from tests?

@Yuki2718
Copy link
Collaborator Author

Yuki2718 commented Jun 1, 2021

@Alex-302 Here new URL: https://regex101.com/r/YdVN2W/1

@Alex-302
Copy link
Member

Alex-302 commented Jun 1, 2021

@ameshkov May we add it?

@ameshkov
Copy link
Member

ameshkov commented Jun 1, 2021

@Yuki2718 I've read the original issue, but I don't understand, why there's no $domain restriction? As I understand, it was tested on a limited number of websites anyway

@zloyden
Copy link
Contributor

zloyden commented Jun 1, 2021

Maybe, there are many domains, but I prefer to use $domain for regex rules.
@Yuki2718 which sites need this rule? Please provide a list of them.

@Yuki2718
Copy link
Collaborator Author

Yuki2718 commented Jun 2, 2021

@ameshkov @zloyden Because this is used by too many pirate sites, short links etc. and they change domain too often. URLs @ghajini listed were just a fraction, in fact animefenix is not included and, say, now in #84655 there are some more examples: https://regex101.com/r/YdVN2W/1 Lucky to me as I wanted to show (\?_=\d+)? part is necessary. If it's limited to certain domain, there's no need to add another regex - just add them to /^(?!.*(bootstrapcdn.com filter.

@ghajini
Copy link

ghajini commented Jun 2, 2021

Its used on so many sites i mentioned (check comments,not just main start comment)
https://github.com/easylist/easylist/issues/6476
specifically mobile movie sites and pirated sites(torrent ,movie streaming sites etc)...as far i see no fp so far in ubo currently...

@ameshkov ameshkov merged commit 27df2bd into master Jun 3, 2021
@Yuki2718 Yuki2718 deleted the add_regex branch June 3, 2021 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants