Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect extended CSS rule causes that JS rules don't work #1147

Closed
AdamWr opened this issue Oct 2, 2019 · 2 comments
Closed

Incorrect extended CSS rule causes that JS rules don't work #1147

AdamWr opened this issue Oct 2, 2019 · 2 comments

Comments

@AdamWr
Copy link
Member

AdamWr commented Oct 2, 2019

Steps to reproduce

  1. Add these rules:
    example.org#?#body > div[class="":has(h1)
    example.org#%#alert(1);
  2. Go here - http://example.org/

Expected behavior

I think that JS rules should still work.

Actual behavior

JS rules don't work.

The real case is here - AdguardTeam/AdguardFilters#41420
It seems that this rule:

cosmopolitan.lt,moteris.lt,panele.lt,manonamai.lt,tavovaikas.lt,delfi.lt#?#a[href="javascript:void(-1);":-abp-has(a[title="[x] Uždaryti"])

from EasyList Lithuania is inccorect and causes that JS rules don't work.

Screenshot:

image

Your environment

  • AdGuard for Windows 7.2.2943 NIGHTLY (CL 1.5.60)
@sxgunchenko
Copy link

css rules validation was improved in core/pull-requests/1860

@AdamWr
Copy link
Member Author

AdamWr commented Sep 25, 2020

It seems that some rules still cause that problem.
I'm not sure if I should open new issue in this repo or maybe create issue in ExtendedCSS repo - https://github.com/AdguardTeam/ExtendedCss/issues, so I'm writing comment here.

Steps to reproduce

  1. Add these rules:
example.org#?#body:has(div),
example.org#%#alert(1);
  1. Go here - http://example.org/

Expected behavior

JS rules should still work.

Actual behavior

JS rules don't work.

Screenshot

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants