Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delfi.lt #41420

Closed
adguard-bot opened this issue Sep 29, 2019 · 23 comments
Closed

delfi.lt #41420

adguard-bot opened this issue Sep 29, 2019 · 23 comments

Comments

@adguard-bot
Copy link

Issue URL (Ads)

https://www.delfi.lt/

Comment

Username: @ArturasRa

I can't block specified ads with your product, event if i try to block this element manually. After the page refresh it comes back.

The information below is automatically generated. Do not delete it.

Referrer:

Custom userscripts:
https://userscripts.adtidy.org/release/assistant/4.3/assistant.meta.js
https://userscripts.adtidy.org/release/adguard-extra/1.0/adguard-extra.meta.js

Screenshots

Screenshot 1

Screenshot 1

System configuration

Information value
Platform: Mac
AdGuard version: 2.1.2.595 release
Browser: Safari
Filters: Filter unblocking search ads and self-promotion,
EasyList Lithuania,
AdGuard Annoyances,
AdGuard Base,
AdGuard Tracking Protection,
AdGuard Social Media
@krystian3w
Copy link
Contributor

Try this:

delfi.lt#?##header-top-banner + [class]:not(.container):has(img[src*="cdn"])

Maybe still works?

@adguard-bot
Copy link
Author

Issue URL (Ads)

https://www.delfi.lt/

Comment

Ads not blocked

Screenshots

Screenshot 1

Screenshot 1

System configuration

Information value
Platform: Ext
AdGuard version: 3.2.1
Browser: Chrome
Stealth mode options:
Filters: AdGuard Russian,
EasyList Czech and Slovak,
EasyList Lithuania,
AdGuard French,
AdGuard Base,
Official Polish filters for AdBlock, uBlock Origin & AdGuard,
AdGuard German,
AdGuard Spanish/Portuguese

@ArturasRa
Copy link

Try this:

delfi.lt#?##header-top-banner + [class]:not(.container):has(img[src*="cdn"])

Maybe still works?

Unfortunately, it doesn't work. :(

@krystian3w
Copy link
Contributor

krystian3w commented Oct 1, 2019

OK, I see this is chromium/blink, apple-safari/webkit specific.

On chromium (#41420 (comment)) can works, but I do not have macOS:

obraz

I suppose AG 2.1.2.595 release no support this (syntax) or website have diffrent layout for Safari.

Also try filter without "?" between "#":

delfi.lt###header-top-banner + [class]:not(.container):has(img[src*="cdn"])

@krystian3w
Copy link
Contributor

krystian3w commented Oct 1, 2019

Or backward syntax (-ext-has=):

delfi.lt###header-top-banner + [class]:not(.container)[-ext-has='> img[src*="cdn"]']
delfi.lt#?##header-top-banner + [class]:not(.container)[-ext-has='> img[src*="cdn"]']

delfi.lt##.container.bb2 > .row > [class][-ext-has='> *[-ext-has='> img[src*="cdn"]']']
delfi.lt#?#.container.bb2 > .row > [class][-ext-has='> *[-ext-has='> img[src*="cdn"]']']

@krystian3w
Copy link
Contributor

Latest addon v3 for Firefox / Chrome / Opera / Yandex:
||adform.net/banners/scripts/adx.js$script,redirect=noopjs

for apps if support:
||adform.net/banners/scripts/adx.js$empty

@ArturasRa
Copy link

Well, tried all those rules, same results - ad remains. :(

I hope I'm doing it right.

image

After that I'm just refreshing that page in the browser.

@AdamWr
Copy link
Member

AdamWr commented Oct 1, 2019

@ArturasRa Could you please check this rule:
delfi.lt#%#AG_setConstant('_dlf._ab', 'noopFunc');

@ArturasRa
Copy link

@AdamWr - nope, ad remains. It seems it's going to be a challenge to filter it. But those casino ads are really annoying. :/

@AdamWr
Copy link
Member

AdamWr commented Oct 1, 2019

This rule works fine on my end.
Please remove previous rules and add these and check again:

delfi.lt#@%#//scriptlet("abort-on-property-read", "_dlf.ab")
delfi.lt#@%#//scriptlet("set-constant", "__dabd", "noopFunc")
delfi.lt#@%#AG_abortOnPropertyRead('_dlf.ab');
delfi.lt#@%#AG_setConstant('__dabd', 'noopFunc');
delfi.lt#%#AG_setConstant('_dlf._ab', 'noopFunc');

AdamWr added a commit that referenced this issue Oct 1, 2019
@ArturasRa
Copy link

Well, perhaps I'm going something wrong, but that didn't helped. Sorry about that:

image

@AdamWr
Copy link
Member

AdamWr commented Oct 1, 2019

If rules above do not work, please check this:

delfi.lt#%#(function(){var b=window.setTimeout;window.setTimeout=function(a,c){if(!/"#header-top-banner"/.test(a.toString()))return b(a,c)};})();

AdamWr added a commit that referenced this issue Oct 1, 2019
@ArturasRa
Copy link

If rules above do not work, please check this:

delfi.lt#%#(function(){var b=window.setTimeout;window.setTimeout=function(a,c){if(!/"#header-top-banner"/.test(a.toString()))return b(a,c)};})();

Nope, ad remains. Those bastards somehow manages to show it :/

@AdamWr
Copy link
Member

AdamWr commented Oct 2, 2019

It's really strange, because with these rules, ads are blocked on my end.

Screenshot

image

Could you please update filters and disable EasyList Lithuania and check again?
I think that EasyList Lithuania may causes some problems.

@AdamWr AdamWr added the A: In progress Work on the issue is in progress label Oct 2, 2019
@ArturasRa
Copy link

@AdamWr - you are right! With disabled EasyList Lithuania ad becomes blocked.

@AdamWr
Copy link
Member

AdamWr commented Oct 2, 2019

Ok, thank you for your answer.
There is an inccorect rule in EasyList Lithuania which causes the problem.

You can add this rule to User's filter:

cosmopolitan.lt,moteris.lt,panele.lt,manonamai.lt,tavovaikas.lt,delfi.lt#@?#a[href="javascript:void(-1);":-abp-has(a[title="[x] Uždaryti"])

and re-enable EasyList Lithuania.

I will add this rule as a temporary solution to AdGuard Base filter.
Update should be available in 1-2 hours.

AdamWr added a commit that referenced this issue Oct 2, 2019
@krystian3w
Copy link
Contributor

@gymka #41420 (comment)

@gymka
Copy link

gymka commented Oct 2, 2019

@gymka #41420 (comment)

replaced that rule, either easyl;ist lithuania disabled either disabled i can see ads...

@AdamWr
Copy link
Member

AdamWr commented Oct 2, 2019

replaced that rule

Thank you.

either easyl;ist lithuania disabled either disabled i can see ads...

With AdGuard or with another ad blocker?

@gymka
Copy link

gymka commented Oct 2, 2019

i use only adblock plus, so all rules are tested only with adblock plus. feels like adblock plus will be last who could fight such ads :D not only adguard can fight such ads... and adblock plus still can't :D
for the record: test rules not by pressing F5, but by closing and reopening browser. code changes almost daily. i spent to much time for this site.

@AdamWr
Copy link
Member

AdamWr commented Oct 2, 2019

If I'm not wrong, at the moment they are checking if this request is blocked
image

and if this class is hidden (they are removing it after a while)
image

so I think that these rules should work with ABP:
delfi.lt#@#.banner
||adform.net/banners/scripts/adx.js$domain=delfi.lt,rewrite=abp-resource:blank-js

At least works fine on my end with these filters:

Screenshot

image

In case if this element is hidden and/or this request is blocked they display different ads.

@AdamWr AdamWr closed this as completed Oct 2, 2019
@AdamWr AdamWr added A: Resolved and removed A: In progress Work on the issue is in progress labels Oct 2, 2019
@krystian3w krystian3w mentioned this issue Oct 10, 2019
@DandelionSprout
Copy link
Member

DandelionSprout commented Jan 26, 2020

I think the entry in #41420 (comment) is simply incorrectly written, as it appears to me personally that a closing ] is missing.

I think it should be turned into cosmopolitan.lt,moteris.lt,panele.lt,manonamai.lt,tavovaikas.lt,delfi.lt#@?#a[href="javascript:void(-1);"]:-abp-has(a[title="[x] Uždaryti"])

@AdamWr
Copy link
Member

AdamWr commented Jan 27, 2020

This rule was added, because there was an incorrect rule in EasyList Lithuania - EasyList-Lithuania/easylist_lithuania@242da9c#diff-de57958f6e85e2b90c3b74fe181d4eb9L280 which was causing issue with other rules.

As I see this rule was removed, so I guess we can remove this exception too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants