Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert [$domain=/regex/] to /regex/(cosmetic rule) for uBO version of lists #204

Open
Yuki2718 opened this issue Dec 30, 2023 · 4 comments
Open

Convert [$domain=/regex/] to /regex/(cosmetic rule) for uBO version of lists #204

Yuki2718 opened this issue Dec 30, 2023 · 4 comments
Assignees
@maximtop
Labels
Priority: P4

Comments

@Yuki2718
Copy link

Yuki2718 commented Dec 30, 2023 •
edited
Loading

gorhill/uBlock@8149847
@Yuki2718 Yuki2718 mentioned this issue Dec 30, 2023
Closed
@Yuki2718 Yuki2718 changed the title Convert [$domain=/regex/] to $domain=/regex/ for uBO version of lists Convert [$domain=/regex/] to $domain=/regex/ or /regex/## for uBO version of lists Dec 30, 2023
@adguard-bot adguard-bot changed the title Convert [$domain=/regex/] to $domain=/regex/ or /regex/## for uBO version of lists Convert [$domain=/regex/] to $domain=/regex/ for uBO version of lists Dec 30, 2023
@Yuki2718 Yuki2718 changed the title Convert [$domain=/regex/] to $domain=/regex/ for uBO version of lists Convert [$domain=/regex/] to $domain=/regex/ or /regex/(cosmetic rule) for uBO version of lists Dec 30, 2023
@Yuki2718 Yuki2718 changed the title Convert [$domain=/regex/] to $domain=/regex/ or /regex/(cosmetic rule) for uBO version of lists Convert [$domain=/regex/] to /regex/(cosmetic rule) for uBO version of lists Dec 30, 2023
@Yuki2718 Yuki2718 mentioned this issue Jan 31, 2024
Closed
9 tasks
@Alex-302 Alex-302 mentioned this issue Sep 11, 2024
Closed
@punisher018
Copy link

punisher018 commented Sep 11, 2024 •
edited
Loading

Can you have a look at the filters of the dizipal811.com topic above? Their format is not supported by ublock. @Yuki2718

@Yuki2718
Copy link
Author

I missed the notification, only noticed when I'm checking email. But what to look for? I don't see any regex filter for dizipal* in uBO version of AdGuard Turkish filter.

@punisher018
Copy link

@Yuki2718, @Alex-302 added the filters suitable for uBO. So there is no problem for now. (If the number of domain addresses of the site exceeds 825, it will be necessary to update.) But the regex filters are still there, if you want to take a look. (Line 5510 - 5514)
https://github.com/AdguardTeam/AdguardFilters/commit/cbe528924cf2a93f753bb115467d7e04119ceee0

@Yuki2718
Copy link
Author

yeah, I found and don't know why missed them. But as said, [$domain=/dizipal\d+.com/] is not supported by uBO.

@Yuki2718 Yuki2718 mentioned this issue Sep 21, 2024
Closed
11 tasks
gorhill added a commit to gorhill/uBlock that referenced this issue Oct 8, 2024
@gorhill
Add support to parse Adguard's [$domain=/.../] regex-based modifier
58bfe4c 
The modifier will be converted to one that is compatible with uBO, i.e.:

    [$domain=/^trgoals\d+\.xyz$/]##+js(set-constant, isShow, true)

Will parsed as equivalent of:

    /^trgoals\d+\.xyz$/##+js(set-constant, isShow, true)

Related issue:
AdguardTeam/FiltersCompiler#204

Reference:
https://adguard.com/kb/general/ad-filtering/create-own-filters/#non-basic-domain-modifier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximtop maximtop

Labels
Priority: P4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@maximtop @adguard-bot @punisher018 @Yuki2718