Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong compilation of a scriptlet rule #211

Open
Yuki2718 opened this issue Feb 4, 2024 · 1 comment
Open

Wrong compilation of a scriptlet rule #211

Yuki2718 opened this issue Feb 4, 2024 · 1 comment
Assignees

Comments

@Yuki2718
Copy link

Yuki2718 commented Feb 4, 2024

IDK what is causing this, but amazon.de,amazon.co.jp,amazon.com#%#//scriptlet('xml-prune', 'xpath(//*[name()="Period"][.//*[@value="Ad"]] | //*[name()="Period"]/@start)', '[value="Ad"]', '.mpd') for uBO in Base is compiled into amazon.de,amazon.co.jp,amazon.com#@#+js(xml-prune, xpath(//*[name()="Period"][.//*[@value="Ad"]] | //*[name()="Period"]/@start), [value="Ad"], .mpd) and causing problem.

@Yuki2718
Copy link
Author

Yuki2718 commented Feb 4, 2024

Another case spotted by @liamengland1 pluto.tv#%#//scriptlet('xml-prune', 'xpath(//*[name()="Period"][.//*[name()="BaseURL" and contains(text(),"_ad")]] | //*[name()="Period"]/@start | //*[name()="Period"]/@duration', '', '.mpd') => pluto.tv#@#+js(xml-prune, xpath(//*[name()="Period"][.//*[name()="BaseURL" and contains(text()\,"_ad")]] | //*[name()="Period"]/@start | //*[name()="Period"]/@duration, , .mpd)

Yuki2718 added a commit to AdguardTeam/AdguardFilters that referenced this issue Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants