add more tests

AdguardTeam · Oct 2, 2023 · b912971 · b912971
1 parent 5b79151
commit b912971
Showing 1 changed file with 32 additions and 7 deletions.
diff --git a/__tests__/filters-downloader.test.js b/__tests__/filters-downloader.test.js
@@ -515,9 +515,10 @@ QUnit.test('Test filter downloader - nested if conditions', async (assert) => {
 
 });
 
-// FIXME: add checking of thrown error messages
-// FIXME: add tests for invalid !#else
 QUnit.test('Test filter downloader - invalid "if" conditions', async (assert) => {
+    const FilterDownloader = require('../src');
+    assert.ok(FilterDownloader);
+
     let rules;
 
     rules = [
@@ -526,10 +527,6 @@ QUnit.test('Test filter downloader - invalid "if" conditions', async (assert) =>
         'invalid_if_space',
         '!#endif'
     ];
-
-    const FilterDownloader = require('../src');
-    assert.ok(FilterDownloader);
-
     assert.throws(() => {
         FilterDownloader.resolveConditions(rules, FilterCompilerConditionsConstants);
     });
@@ -539,7 +536,17 @@ QUnit.test('Test filter downloader - invalid "if" conditions', async (assert) =>
         '!#if adguard',
         'missing_endif'
     ];
+    assert.throws(() => {
+        FilterDownloader.resolveConditions(rules, FilterCompilerConditionsConstants);
+    });
 
+    rules = [
+        'always_included_rule',
+        '!#if adguard',
+        'if_rule',
+        '!#else',
+        'missing_endif',
+    ];
     assert.throws(() => {
         FilterDownloader.resolveConditions(rules, FilterCompilerConditionsConstants);
     });
@@ -549,7 +556,15 @@ QUnit.test('Test filter downloader - invalid "if" conditions', async (assert) =>
         'invalid_endif',
         '!#endif'
     ];
+    assert.throws(() => {
+        FilterDownloader.resolveConditions(rules, FilterCompilerConditionsConstants);
+    });
 
+    rules = [
+        'always_included_rule',
+        '!#else',
+        'invalid_else',
+    ];
     assert.throws(() => {
         FilterDownloader.resolveConditions(rules, FilterCompilerConditionsConstants);
     });
@@ -560,7 +575,18 @@ QUnit.test('Test filter downloader - invalid "if" conditions', async (assert) =>
         'invalid_condition',
         '!#endif'
     ];
+    assert.throws(() => {
+        FilterDownloader.resolveConditions(rules, FilterCompilerConditionsConstants);
+    });
 
+    rules = [
+        'always_included_rule',
+        '!#if adguard_ext_chromium',
+        'if_chromium_rule',
+        '!#elseif adguard_ext_firefox',
+        'invalid_else',
+        '!#endif'
+    ];
     assert.throws(() => {
         FilterDownloader.resolveConditions(rules, FilterCompilerConditionsConstants);
     });
@@ -571,7 +597,6 @@ QUnit.test('Test filter downloader - invalid "if" conditions', async (assert) =>
         'invalid_condition_brackets',
         '!#endif'
     ];
-
     assert.throws(() => {
         FilterDownloader.resolveConditions(rules, FilterCompilerConditionsConstants);
     });