Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quic-go to v0.35.1 #331

Closed
Potterli20 opened this issue May 31, 2023 · 8 comments
Closed

Update quic-go to v0.35.1 #331

Potterli20 opened this issue May 31, 2023 · 8 comments

Comments

@Potterli20
Copy link

Potterli20 commented May 31, 2023

When will quic-go be updated?@EugeneOne1

https://github.com/quic-go/quic-go

@Potterli20
Copy link
Author

Potterli20 commented Jun 1, 2023

@Potterli20 Potterli20 changed the title update quic-go 0.35.0? update quic-go 0.35.1? Jun 1, 2023
@EugeneOne1 EugeneOne1 self-assigned this Jun 1, 2023
@EugeneOne1
Copy link
Member

@ameshkov, we've took a look at the changes between versions v0.33.0 (currently used) and v0.35.1. There are some breaking changes that may potentially affect our configuration.

For example, the Tracer field of quic.Config previously having the logging.Tracer type is now a callback returning the logging.ConnectionTracer. These are really different interfaces and it's unclear what should we do. Also, some types (quic.EarlyListener) have became structures since v0.33.0.

At first glance, these are the only breaking changes (except for some renaming), but I suppose we need to discuss the changes.

@EugeneOne1 EugeneOne1 removed their assignment Jun 1, 2023
@Potterli20
Copy link
Author

Potterli20 commented Jun 2, 2023

@ameshkov When is the big update?
If you want to update adh, update it too

@Potterli20
Copy link
Author

@ameshkov, we've took a look at the changes between versions v0.33.0 (currently used) and v0.35.1. There are some breaking changes that may potentially affect our configuration.

For example, the Tracer field of quic.Config previously having the logging.Tracer type is now a callback returning the logging.ConnectionTracer. These are really different interfaces and it's unclear what should we do. Also, some types (quic.EarlyListener) have became structures since v0.33.0.

At first glance, these are the only breaking changes (except for some renaming), but I suppose we need to discuss the changes.

Brother, can you find your boss and ask when this will be updated?

@ameshkov ameshkov changed the title update quic-go 0.35.1? Update quic-go to v0.35.1 Jun 3, 2023
@Potterli20
Copy link
Author

Potterli20 commented Jun 6, 2023

update dns to v1.1.54?

miekg/dns@v1.1.50...v1.1.54

@Potterli20 Potterli20 changed the title Update quic-go to v0.35.1 Update quic-go to v0.35.1 and dns to 1.1.54 Jun 6, 2023
@adguard adguard closed this as completed in af10111 Jun 6, 2023
@EugeneOne1
Copy link
Member

@Potterli20, we're trying to keep the dependencies up-to-date, but it isn't always the highest priority. So eventually we'll update the dns library as well, and you may even create a separate issue about it.

@Potterli20
Copy link
Author

@Potterli20, we're trying to keep the dependencies up-to-date, but it isn't always the highest priority. So eventually we'll update the dns library as well, and you may even create a separate issue about it.

okok

@Potterli20 Potterli20 changed the title Update quic-go to v0.35.1 and dns to 1.1.54 Update quic-go to v0.35.1 Jun 6, 2023
@Potterli20
Copy link
Author

@Potterli20, we're trying to keep the dependencies up-to-date, but it isn't always the highest priority. So eventually we'll update the dns library as well, and you may even create a separate issue about it.

Dependent on updates, I've raised this before, but there's no follow-up later

adguard pushed a commit that referenced this issue May 8, 2024
…ng of dead cached QUIC connections

Merge in GO/dnsproxy from fix-389-doq to master

Closes #331

Squashed commit of the following:

commit d6b02d8
Merge: a7734d8 1b1db5b
Author: Andrey Meshkov <am@adguard.com>
Date:   Wed May 8 22:34:40 2024 +0300

    Merge branch 'master' into fix-389-doq

commit a7734d8
Author: Andrey Meshkov <am@adguard.com>
Date:   Sat Apr 27 18:32:35 2024 +0300

    resolve review comments

commit 419dcd2
Author: Andrey Meshkov <am@adguard.com>
Date:   Sat Apr 27 18:01:39 2024 +0300

    resolve review comments

commit 5ec9207
Author: Andrey Meshkov <am@adguard.com>
Date:   Sat Apr 27 17:58:55 2024 +0300

    resolve review comments

commit 075a44c
Merge: 9f73579 e35720f
Author: Andrey Meshkov <am@adguard.com>
Date:   Sat Apr 27 17:39:10 2024 +0300

    merge with master

commit 9f73579
Author: Andrey Meshkov <am@adguard.com>
Date:   Sun Mar 24 23:52:40 2024 +0300

    fix comment

commit 412e684
Merge: 60b21f0 1b67700
Author: Andrey Meshkov <am@adguard.com>
Date:   Sun Mar 24 23:47:38 2024 +0300

    Merge branch 'master' into fix-389-doq

commit 60b21f0
Author: Andrey Meshkov <am@adguard.com>
Date:   Sun Mar 24 23:47:20 2024 +0300

    upstream: fix #389, handle quic conn errors better

commit 0dbc5e8
Author: Andrey Meshkov <am@adguard.com>
Date:   Sun Mar 24 23:20:00 2024 +0300

    upstream: add test to demonstrate #389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants