Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.64.0 can no longer use IPv6 upstream #379

Closed
timkgh opened this issue Jan 29, 2024 · 2 comments
Closed

v0.64.0 can no longer use IPv6 upstream #379

timkgh opened this issue Jan 29, 2024 · 2 comments
Assignees
@schzhn
Labels
bug Something isn't working

Comments

@timkgh
Copy link

timkgh commented Jan 29, 2024 •
edited
Loading

With config:

upstream:
  - "https://[2620:fe::fe:11]/dns-query"
  - "https://[2620:fe::11]/dns-query"

v0.64.0 no longer starts:

Jan 29 08:36:39  dnsproxy[19719]: 2024/01/29 08:36:39 [fatal] error while parsing upstreams configuration: parsing error at index 0: cannot prepare the upstream: invalid address [2620:fe::fe:11]: bad hostname "[2620:fe::fe:11]": bad top-level domain name label "[2620:fe::fe:11]": bad top-level domain name label rune '['
Jan 29 08:36:39  dnsproxy[19719]: parsing error at index 1: cannot prepare the upstream: invalid address [2620:fe::11]: bad hostname "[2620:fe::11]": bad top-level domain name label "[2620:fe::11]": bad top-level domain name label rune '['

It works in v0.63.1
@ainar-g ainar-g added the bug Something isn't working label Jan 29, 2024
adguard pushed a commit that referenced this issue Jan 30, 2024
@schzhn @EugeneOne1
Pull request 317: 379 fix ipv6 upstream
64814cc 
Updates #379.

Co-authored-by: Eugene Burkov E.Burkov@AdGuard.COM

Squashed commit of the following:

commit 767d954
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Tue Jan 30 19:31:07 2024 +0300

    upstream: imp code

commit 313c715
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Tue Jan 30 18:32:55 2024 +0300

    upstream: add todo

commit 83e1561
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Tue Jan 30 17:41:14 2024 +0300

    upstream: imp code

commit 5c48f20
Author: Stanislav Chzhen <s.chzhen@adguard.com>
Date:   Tue Jan 30 14:42:48 2024 +0300

    upstream: fix ipv6 upstream
@schzhn
Copy link
Member

schzhn commented Jan 30, 2024

Thank you for your report. Fixed in v0.64.1.

@timkgh
Copy link
Author

timkgh commented Jan 30, 2024

It works, thanks for the fix!
Could you please log the upstreams at startup? It would be very useful to confirm such cases when using a mix of ipv4 and ipv6. I asked for it a while back, like 2 years ago ... #200

@schzhn schzhn closed this as completed Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schzhn schzhn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ainar-g @timkgh @schzhn