-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ItemLevel Changes #206
ItemLevel Changes #206
Conversation
Fix AdiAddons#195. Advanced design based on pull 178. Item Level Text can be set to 9 different positions through the configuration screen. Upgrade Icon can be set to 9 different positions through the configuration screen.
This works really well and should be integrated into the main branch. May need a little alignment/organization on the options page. |
Implemented in my own fork and tested on 7.3. Works like a charm. Pls Merge |
I merged this changes to my ElvUI fork. |
Hey there!! Just found this post and the changes work perfect! Thank you very much for that and it would be awsome if I would find those changes in the next update! Thanky you again! :-) |
I've made a few minor updates to this pull for the BfA stat squish, some re-coloring and the like. I set the "blue" and "purple" colors in the InventoryItemLevels method to be more like the Blizzard Rare and Epic colors, respectively, but do think they may be a bit hard to read. It's late here though and my eyes are tired. I'm considering changing them to more of a shade of the Cyan and Pink colors that were originally in the list. Happy to see any comments. Sorry my line levels aren't exact, I've added some comments I'm not sure if can attach or propose additional files in this pull (sorry, only an armchair/script coder and haven't used GitHUB much for actual WORK... ;) so here's my adjustments, at around line number 262 in modules/ItemLevel.lua: local colors = { Additionally, I modified the "level ranges" method colors to the following values (around line 370): local maxLevelRanges = { Finally, I made a change to line 204 to set the max iLevel for the "minimum iLevel threshold to show" to 250. |
I didn't even remember I posted this. If anyone encounters this, the way to 'fix' atm is manually changing the location at the addons folder. Change the line 104 from: to: You can also change the numbers after 'button' to change the position in screen. I set my y axis to 1 so it doesn't look weird. It was by default -1 because it meant to be showed on top. (and it does NOT go back to default when the AdiBags update) |
Closed in favor of #496. |
Fix #195.
Advanced design based on pull 178.
Item Level Text can be set to 9 different positions through the configuration screen.
Upgrade Icon can be set to 9 different positions through the configuration screen.