Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several minor fixes & enhancements to GoSNS #202

Merged
merged 2 commits into from
Oct 15, 2019

Conversation

mbklein
Copy link
Contributor

@mbklein mbklein commented Sep 27, 2019

  • Use the configured account ID instead of 000000000000 in topic ARNs
  • Add support for RawMessageDelivery & FilterPolicy to the Subscribe action
  • Add more attributes to GetSubscriptionAttributes response to bring in line with the AWS response

If you'd prefer these split out into separate atomic PRs, let me know and I'll resubmit.

Add support for RawMessageDelivery & FilterPolicy to SNS subscribe

Add more attributes to GetSubscriptionAttributes response
@mbklein
Copy link
Contributor Author

mbklein commented Sep 27, 2019

I don't know where the errors on travis on this or my other PR are coming from – they're in the test setup, not the tests themselves.

@p4tin
Copy link
Collaborator

p4tin commented Sep 27, 2019 via email

@mbklein
Copy link
Contributor Author

mbklein commented Sep 27, 2019

Yes

Copy link
Collaborator

@p4tin p4tin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code looks good but is there anyway I could ask you to add some unit tests please? Thanks for the PR keep'em coming 💯 Also if you close this PR and do another one it should use github actions instead of travisCI and the test pass there 👍

@p4tin p4tin merged commit 9436ebb into Admiral-Piett:master Oct 15, 2019
@mbklein mbklein deleted the update_sns_api branch October 15, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants