gosqs added support to cancel context for sqs ReceiveMessage() #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 17, 2019 23:39
…the client cancels a waiting receiveMessage(), goaws risks to send a subsequent message from queue to a receive() handler that no client listens to and make this message not visible to pickup by other receiver until WaitTimeSeconds is reached
…o support go 1.12
p4tin
approved these changes
Oct 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this if the client cancels a waiting ReceiveMessage(), goaws risks to send a subsequent message from queue to a ReceiveMessage() handler that no client listens to and make this message not visible to pickup by other active receivers until WaitTimeSeconds is reached