Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for Fedora 41 #786

Merged
merged 1 commit into from
Nov 2, 2024
Merged

Conversation

geragio
Copy link
Contributor

@geragio geragio commented Nov 2, 2024

This PR closes #779. It adds the support to Fedora 41.

Fedora 41 uses TuneD as a default power profile management daemon and it is conflicting with auto-cpufreq service.

Thanks to this PR, TuneD is automatically disabled when installing auto-cpufreq.

@AdnanHodzic AdnanHodzic merged commit 6a13948 into AdnanHodzic:master Nov 2, 2024
1 of 2 checks passed
@AdnanHodzic
Copy link
Owner

Perfect!

Thank you for your contribution, you will be credited for your work as part of future release.

@shadeyg56 btw since I remember you were the one maintaining the Nix package, Nix flake / build-nix (pull_request) checks failed. It all LGTM so I overruled it and merged it anyways.

@AdnanHodzic
Copy link
Owner

@geragio btw I noticed one thing that could be improved, when remove auto-cpufreq daemon, you'll be greeted with following message in case you don't have or use TuneD at all:

* Enabling GNOME power profiles

Removed "/etc/systemd/system/power-profiles-daemon.service".
Created symlink /etc/systemd/system/graphical.target.wants/power-profiles-daemon.service → /usr/lib/systemd/system/power-profiles-daemon.service.
* Enabling TuneD

Unit tuned.service does not exist, proceeding anyway.
Failed to enable unit: Unit file tuned.service does not exist.

So if you have time in future, it would be good to make an improvement where this message will not be outputted if tuned is not present on the system as it could be confusing for some folks.

@geragio
Copy link
Contributor Author

geragio commented Nov 3, 2024

@AdnanHodzic that's a valid point, thanks a lot for your suggestion.
I'll take a look and see how to improve this 👍

@geragio
Copy link
Contributor Author

geragio commented Nov 3, 2024

@AdnanHodzic the PR #788 improves the detection mechanism of TuneD on the host.
We probably need something similar for GNOME power profiles, I'm not sure all distros have it by default.

Let me know what do you think, your feedback is more than welcome!

@AdnanHodzic
Copy link
Owner

@geragio love it! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service stops after reboot - Fedora 41 tuned conflicts
2 participants