Prevent URL modification on dismiss #3338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidjgonzalez
approved these changes
May 10, 2024
davidjgonzalez
merged commit c8e8c09
into
Adobe-Consulting-Services:master
19 checks passed
YegorKozlov
pushed a commit
to YegorKozlov/acs-aem-commons
that referenced
this pull request
Jul 11, 2024
* Prevent URL modification on dismiss * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users dismiss notifications today, the href value of # is added to the current page. Although this does not cause compatibility issues, it's a pseudo-navigation that adds no value. Preventing this with preventDefault() will not negatively impact the system notifications at all and it will prevent conflicts with SPAs and other interactions while there is a non-default URI fragment in place.