#3443 Content Sync: don't drill down into content tree if recursion is off #3452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwin
reviewed
Oct 22, 2024
| @Override | ||
| public List<CatalogItem> getItems(SlingHttpServletRequest request) { | ||
| String rootPath = request.getParameter("root"); | ||
| if (rootPath == null) { | ||
| throw new IllegalArgumentException("root request parameter is required"); | ||
| } | ||
| boolean recursive = "true".equals(request.getParameter("recursive")); | ||
| boolean nonRecursive = "false".equals(request.getParameter("recursive")); |
There was a problem hiding this comment.
Boolean.valueOf(...) to be case insensitive maybe?
kwin
approved these changes
Oct 22, 2024
davidjgonzalez
merged commit 886313d
into
Adobe-Consulting-Services:master
9 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3443