Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to minimize JS when using aio app:deploy #90

Open
sarahxxu opened this issue Jan 20, 2021 · 1 comment
Open

Document how to minimize JS when using aio app:deploy #90

sarahxxu opened this issue Jan 20, 2021 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@sarahxxu
Copy link
Collaborator

Forking @moritzraho 's answer here to be documented --

Developer can replace our build script with a build-static hook in the package.json scripts field. https://www.adobe.io/apis/experienceplatform/project-firefly/docs.html#!AdobeDocs/project-firefly/master/guides/app-hooks.md

We did not minify by default because this was introducing bugs in some cases. However, we do tree shaking (remove uneeded code in deps) and this has shown to reduce the size already enough in most cases.

@meryllblanchet meryllblanchet added the documentation Improvements or additions to documentation label Jan 20, 2021
@meryllblanchet meryllblanchet added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Feb 19, 2021
@aiojbot
Copy link

aiojbot commented Feb 20, 2021

JIRA issue created: https://jira.corp.adobe.com/browse/AIOE-475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants