-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggested documentation changes for github integration with adobe commerce cloud #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you use `magento-cloud integration:add --type=github --project=XXXXXX --base-url=https://github.com --token=XXXXXXXXX --repository={account}/{repository-name} ` you might end up with an error like "The integration is invalid. The following error was found: repository: Unable to connect to GitHub: repository not found". Even though the repository exists and token has all the proper permissions, documentation is misleading because it does not PROPERLY and FULLY mentioning that "base-url" is needed only when repository is on a private server. This needs to be as clear as possible.
marmureanuweb
changed the title
Suggest documentation changes for github integration
Suggested documentation changes for github integration with adobe commerce cloud
Sep 17, 2024
jeff-matthews
added
major-update
Significant updates to content
technical
Changes to code, examples, or technical processes
and removed
major-update
Significant updates to content
labels
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @marmureanuweb.
jeff-matthews
approved these changes
Sep 17, 2024
@devops-devdocs import the pr |
@devops-devdocs imported this pull request |
@devops-devdocs import the pr |
@devops-devdocs imported this pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you use
magento-cloud integration:add --type=github --project=XXXXXX --base-url=https://github.com --token=XXXXXXXXX --repository={account}/{repository-name}
you might end up with an error like "The integration is invalid. The following error was found: repository: Unable to connect to GitHub: repository not found". Even though the repository exists and token has all the proper permissions, documentation is misleading because it does not PROPERLY and FULLY mentioning that "base-url" is needed only when repository is on a private server. This needs to be as clear as possible.Purpose of this pull request
This pull request (PR) updated the documentation for integration of Adobe Commerce Cloud with a private repository from Github
Affected pages