Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Admin configuraiton details #152

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Add Admin configuraiton details #152

merged 5 commits into from
Feb 13, 2024

Conversation

keharper
Copy link
Contributor

Purpose of this pull request

This pull request (PR) adds details to the Admin configuration topic, created in #147. I also discovered some omissions from when conditional webhooks were introductions. This PR also contains some miscellaneous cleanup.

Affected pages

  • ...

Links to Magento Open Source code

  • ...

@keharper keharper added editorial Typo and grammar fixes or minor rewrites to correct inaccuracies internal Differentiates work between external and internal contributors labels Feb 13, 2024
@keharper keharper self-assigned this Feb 13, 2024
src/pages/webhooks/admin-configuration.md Outdated Show resolved Hide resolved
src/pages/webhooks/admin-configuration.md Outdated Show resolved Hide resolved
src/pages/webhooks/admin-configuration.md Outdated Show resolved Hide resolved
Co-authored-by: Jared Hoover <98363870+jhadobe@users.noreply.github.com>
src/pages/webhooks/commands.md Outdated Show resolved Hide resolved
src/pages/webhooks/xml-schema.md Outdated Show resolved Hide resolved
**Active** | Indicates whether to skip a removed hook during the batch execution.
**Method** | The HTTP method (POST, PUT, GET, or DELETE) used to invoke the hook.

### Configure hook fields
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One idea from Sasha was to show screenshots of each of the fields/headers/rules section. For fields though, there is already a screenshot later in the Edit an existing hook section, but it's for the case when there are xml-defined hook fields that can't be edited

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided against adding screenshots for the bottom half of the configuration screen. The UI is repetitive and I don't think adding the screenshots really adds anything.


<InlineAlert variant="warning" slots="text" />

On Cloud instances, due to the read-only file system, the `webhooks:generate:module` command cannot be run. If a plugin-type webhook is added through the Admin, the method name and type should be declared in a `webhooks.xml` file so that the required plugin is generated during the build phase of the deployment process.
If the plugin for the webhook method and type entered into the form have not been generated for the Commerce instance, a warning to run the `webhooks:generate:module` command will appear upon clicking **Save**. You cannot run the `webhooks:generate:module` command on Cloud instances, due to its read-only file system. If you add a plugin-type webhook through the Admin, declare the method name and type in a `webhooks.xml` file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could consider just adding a mention of deploying after declaring the method name and type in a webhooks.xml file since it's during the deployment process that the needed plugin class would get generated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided to leave this as-is. I added a statement to the events and webhooks generate:module commands stating they're for on-premises only,

@keharper keharper merged commit 7506e5c into main Feb 13, 2024
4 checks passed
@keharper keharper deleted the kh_admin-webhooks branch February 13, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Typo and grammar fixes or minor rewrites to correct inaccuracies internal Differentiates work between external and internal contributors
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants