Update Admin UI SDK documentation for 1.4.0 release #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keharper
added
internal
keharper
requested changes
Mar 19, 2024
| } | ||
| } else { | ||
| json_response = [{ | ||
| const json_response = { |
There was a problem hiding this comment.
Will people upgrading to 1.4.0 need to make these updates?
Is a sample server.js file provided? If yes, it might be better to point to it rather than trying to keep this up to date.
There was a problem hiding this comment.
The non updated version will still work as expected. I agree it's better to have a file that we update in the repository, let me double check if we already publish it, if not I can do so.
Co-authored-by: Kevin Harper <keharper@users.noreply.github.com>
Co-authored-by: Kevin Harper <keharper@users.noreply.github.com>
keharper
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) ...
Affected pages
Links to Magento Open Source code