Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a linter to validate external links #148

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Add a linter to validate external links #148

merged 4 commits into from
Nov 28, 2023

Conversation

dshevtsov
Copy link
Contributor

Purpose of this pull request

This pull request (PR):

  • Adds a plugin remark-lint-no-dead-urls to ensure that external URLs in Markdown pages are working. The linter returns warnings on https://www.php.net/ on working links in some reason (I assume server related issues) so I excluded this domain in the configuration.
  • Replaces or removes dead links

Internal ticket: COMDOX-156

Test

Failed validate job reporting about dead links.

@dshevtsov dshevtsov added the enhancement New feature or request label Nov 21, 2023
@dshevtsov dshevtsov self-assigned this Nov 21, 2023
@dshevtsov
Copy link
Contributor Author

dshevtsov commented Nov 21, 2023 •
edited
Loading

@bdenham please see a report and fix the links.

@bdenham bdenham marked this pull request as ready for review November 28, 2023 23:34
@bdenham bdenham merged commit bf562d8 into AdobeDocs:main Nov 28, 2023
2 checks passed
@bdenham bdenham deleted the ds_url-linter branch November 28, 2023 23:43
@jeff-matthews jeff-matthews added the internal Differentiate between community and staff member label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdenham bdenham bdenham approved these changes

@jeff-matthews jeff-matthews Awaiting requested review from jeff-matthews

Assignees

@dshevtsov dshevtsov

Labels
enhancement New feature or request internal Differentiate between community and staff member
Projects
Commerce - Pull Requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dshevtsov @bdenham @jeff-matthews