Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation for custom headers #150

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Add validation for custom headers #150

merged 3 commits into from
Nov 30, 2023

Conversation

dshevtsov
Copy link
Contributor

Purpose of this pull request

This pull request (PR) adds a remark-heading-id plugin that allows validation of custom headers via remark-validate-links.

Test

See AdobeDocs/commerce-admin-developer#85

@dshevtsov dshevtsov added the enhancement New feature or request label Nov 30, 2023
@dshevtsov dshevtsov self-assigned this Nov 30, 2023
jeff-matthews
jeff-matthews approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@jeff-matthews jeff-matthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since I see the validation job has successfully passed the link check step.

@dshevtsov dshevtsov marked this pull request as ready for review November 30, 2023 18:35
@dshevtsov dshevtsov merged commit dd11257 into AdobeDocs:main Nov 30, 2023
@dshevtsov dshevtsov deleted the ds_custom-header-check branch November 30, 2023 18:36
@jeff-matthews jeff-matthews added the internal Differentiate between community and staff member label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeff-matthews jeff-matthews jeff-matthews approved these changes

@bdenham bdenham Awaiting requested review from bdenham

Assignees

@dshevtsov dshevtsov

Labels
enhancement New feature or request internal Differentiate between community and staff member
Projects
Commerce - Pull Requests
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dshevtsov @jeff-matthews