Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial on how to add a custom product attribute input type #150

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

goivvy
Copy link

@goivvy goivvy commented May 8, 2023

Purpose of this pull request

This pull request (PR) adds a tutorial on how to create a custom product attribute input type. It fixes magento/devdocs#9452 .

Affected pages

  • ...

Links to Magento Open Source code

  • ...

@goivvy goivvy changed the title Custom attribute input type Tutorial on how to add a custom product attribute input type May 8, 2023
@jeff-matthews jeff-matthews self-assigned this May 9, 2023
@jeff-matthews jeff-matthews added the new-topic A major update published as an entirely new document label May 9, 2023
@jeff-matthews
Copy link
Contributor

Thanks for the contribution @goivvy! While we review, will you please sign the Adobe CLA? It's a requirement for us to merge external contributions.

@rparsi-boxycharm, since you were the original reporter for magento/devdocs#9452, would you please take a look and share your feedback?

@goivvy
Copy link
Author

goivvy commented May 9, 2023

@jeff-matthews Where is a link to sign the CLA?

@jeff-matthews
Copy link
Contributor

@goivvy, if you don't see the link next to the check, then there must be a bug and I'll need to contact the Adobe Open Source Office for assistance. Do you see a link? I assume I don't see it because it's contributor-specific.

Screenshot 2023-05-09 at 10 09 28 AM

@goivvy
Copy link
Author

goivvy commented May 9, 2023

@jeff-matthews I see it but it's not active. I click on it and nothing happens. I signed CLA for https://github.com/magento/devdocs a few years ago, is that different?

@jeff-matthews
Copy link
Contributor

Yes, each repo requires a separate signed CLA as far as I know.

Can you see a "Details" link next to the check? I can't, but I don't know if I'm supposed to if I'm not the contributor.

@goivvy
Copy link
Author

goivvy commented May 9, 2023

@jeff-matthews That's how I see it:
Screenshot 2023-05-09 at 11 51 44 AM

@jeff-matthews
Copy link
Contributor

Thanks @goivvy. It looks like there was a GitHub service issue earlier today. We may just need to wait while all services come back and the job queue clears.

https://www.githubstatus.com/

@goivvy
Copy link
Author

goivvy commented May 10, 2023

@jeff-matthews Still no link to accept the CLA.
Screenshot 2023-05-10 at 9 18 48 AM

@jeff-matthews
Copy link
Contributor

@goivvy, can you please try opening a new, test PR in this repo? Maybe the test PR will have the CLA link and we can assume this is a transient issue with the https://github.com/adobe/cla-bot/.

@goivvy
Copy link
Author

goivvy commented May 10, 2023

@jeff-matthews I created a test PR but I still don't see a link to sign the CLA - #153

@jeff-matthews
Copy link
Contributor

Thanks @goivvy. I'll work with the maintainers to see how to fix it.

@jeff-matthews
Copy link
Contributor

jeff-matthews commented May 12, 2023

@goivvy, now that GitHub services are all back online and queues have been processed, it looks like the link for the CLA check is now showing as expected. 🙌

And it looks like you've already signed it 😄

@goivvy
Copy link
Author

goivvy commented May 12, 2023

@jeff-matthews I didn't do anything, my signature must've been migrated from the old repo

@goivvy
Copy link
Author

goivvy commented May 22, 2023

@jeff-matthews Let me know if you need me to explain code block in the tutorial.

@jeff-matthews
Copy link
Contributor

Sorry about the delay @goivvy. I haven't forgotten about this, but I won't be able to get someone to look at it until after our 2.4.7-beta release on 6/13.

@goivvy
Copy link
Author

goivvy commented Jul 6, 2023

@jeff-matthews Alright, it sounds good

@jeff-matthews
Copy link
Contributor

I think I found someone to review. Contacted internal engineering manager for assistance.

@goivvy
Copy link
Author

goivvy commented Jul 13, 2023

@jeff-matthews OK, any questions - let me know.

@goivvy
Copy link
Author

goivvy commented Nov 13, 2023

@jeff-matthews I was wondering if they had a chance to review the article.

@jeff-matthews
Copy link
Contributor

Hi @goivvy,

I checked with the team member (Abhinav Pathak) who is assigned to review last week and they said that they have not started yet. Hopefully, they'll look at it this week.

@goivvy
Copy link
Author

goivvy commented Feb 16, 2024

@jeff-matthews let me know if they had a chance to review the code.

@jeff-matthews
Copy link
Contributor

Hi @goivvy,

Confirmed that they're reviewing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-topic A major update published as an entirely new document
Projects
Status: 🧑‍💻 In Progress
Development

Successfully merging this pull request may close these issues.

No developer level documentation on how to programmatically (in code) create a custom attribute input type
3 participants