Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storefront installation failed with node 18.15.0 #172

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

glo82145
Copy link
Collaborator

@glo82145 glo82145 commented Mar 24, 2023

Description

Describe the bug

Per the PWA Studio Get Started doc...

PWA Studio supports NodeJS Long Term Support (LTS) versions, currently v16 and v18, which are always even-numbered.

However, when I try and run using these instructions with Node 18 it fails. I am only able to successfully get it to run with Node 16

To reproduce

Steps to reproduce the behavior:

Switch to use Node 18...
``{{
❯ nvm use 18
Now using node v18.12.1 (npm v8.19.2)
}}{{ Run the scaffolding tool and answer the questions }}{{
❯ npx @magento/create-pwa
@magento/create-pwa v2.3.3
Creating a PWA Studio project
? Project root directory (will be created if it does not exist) testing1
? Short name of the project to put in the package.json "name" field testing1
? Name of the author to put in the package.json "author" field Someone [someone@example.com]
? Which template would you like to use to bootstrap testing1? Defaults to "@magento/venia-concept". @magento/venia-concept
? Magento instance to use as a backend (will be added to }}.env{{ file) 2.4-develop
? Edition of the magento store (Adobe Commerce or Magento Open Source) AC
? Braintree API token to use to communicate with your Braintree instance (will be added to }}.env{{ file) sandbox_8yrzsvtm_s2bg8fs563crhqzk
? NPM package management client to use npm
? Install package dependencies with npm after creating project Yes
Running command:

buildpack create-project testing1 --name "testing1" --author "Someone [someone@example.com]" --template "@magento/venia-concept" --backend-url "https://venia-develop-ccewfjy-mfwmkrjfqvbjk.us-4.magentosite.cloud/" --backend-edition "AC" --braintree-token "sandbox_8yrzsvtm_s2bg8fs563crhqzk" --npm-client "npm"

ℹ Found @magento/venia-concept template in cache
ℹ Creating a new PWA project 'testing1' in testing1
(node:30250) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use }}node --trace-warnings ...{{ to show where the warning was created)
ℹ Successfully wrote a fresh configuration file to /Users/stephanieglaser/Sites/pwa-studio/testing1/.env
npm WARN ERESOLVE overriding peer dependency
npm WARN ERESOLVE overriding peer dependency
npm WARN ERESOLVE overriding peer dependency
npm WARN ERESOLVE overriding peer dependency
npm WARN ERESOLVE overriding peer dependency
npm WARN ERESOLVE overriding peer dependency
npm WARN deprecated @npmcli/move-file@1.1.2: This functionality has been moved to @npmcli/fs
npm WARN deprecated source-map-url@0.4.1: See https://github.com/lydell/source-map-url#deprecated
npm WARN deprecated stable@0.1.8: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility
npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
npm WARN deprecated source-map-resolve@0.5.3: See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated querystring@0.2.1: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
npm WARN deprecated w3c-hr-time@1.0.2: Use your platform's native performance.now() and performance.timeOrigin.
npm WARN deprecated mini-create-react-context@0.4.1: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm WARN deprecated fsevents@1.2.13: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
npm WARN deprecated chokidar@2.1.8: Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies
npm WARN deprecated debug@4.1.1: Debug versions >=3.2.0 [3.2.7 || ]=4 [4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/debug-js/debug/issues/797)
npm WARN deprecated chokidar@2.1.8: Chokidar 2 does not receive security updates since 2019. Upgrade to chokidar 3 with 15x fewer dependencies
npm WARN deprecated fsevents@1.2.13: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2.
npm WARN deprecated querystring@0.2.0: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
npm WARN deprecated babel-eslint@10.1.0: babel-eslint is now @babel/eslint-parser. This package will no longer receive updates.
npm WARN deprecated mkdirp@0.3.0: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)
npm WARN deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.
npm WARN deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.
npm WARN deprecated devcert@1.1.3: critical regex denial of service bug fixed in 1.2.1 patch
npm WARN deprecated subscriptions-transport-ws@0.9.19: The }}subscriptions-transport-ws{{ package is no longer maintained. We recommend you use }}graphql-ws{{ instead. For help migrating Apollo software to }}graphql-ws{{, see https://www.apollographql.com/docs/apollo-server/data/subscriptions/#switching-from-subscriptions-transport-ws For general help using }}graphql-ws{{, see https://github.com/enisdenjo/graphql-ws/blob/master/README.md

added 2546 packages, and audited 2547 packages in 1m

248 packages are looking for funding
run }}npm fund{{ for details

65 vulnerabilities (14 moderate, 37 high, 14 critical)

To address all issues possible (including breaking changes), run:
npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run }}npm audit{{ for details.
✔ Installed dependencies for 'testing1' project
⚠ Created new PWA project testing1. Next steps:

cd testing1 before running the below commands.
npm run buildpack – create-custom-origin . to generate a unique, secure custom domain for your new project. Highly recommended.
npm run watch to start the dev server and do real-time development.
npm run storybook to start Storybook dev server and view available components in your app.
npm run build to build the project into optimized assets in the '/dist' directory.
npm start after build to preview the app on a local staging server.
}}{{ Change to the new directory created }}{{
❯ cd testing1
}}{{ Run buildpack }}{{
❯ npm run buildpack – create-custom-origin .
] testing1@0.0.1 buildpack

buildpack create-custom-origin .

venia-sample-backends is a "development-only" extension, please remove it from your project's package.json before going to production.

ⓧ error:0308010C:digital envelope routines::unsupported
ⓧ Error: error:0308010C:digital envelope routines::unsupported
}}`{{

See the error in the returned results (above). If I switch to v16 using }}nvm use 16{{ the previous command runs without error. After being set up successfully, the same error is also thrown after running }}npm run watch{{.
Expected behavior

It should run successfully without throwing an error.

Debug Report

}}`{{
❯ yarn build:report
yarn run v1.22.19
$ buildpack generate-build-report
ℹ Generating build report for testing1@0.0.1. This may take a moment.

ℹ Inspecting Dependencies
Found 10 @magento dependencies in package-lock.json
@magento/pwa-buildpack @ 11.4.1
@adobe/apollo-link-mutation-queue @ 1.0.2
@magento/babel-preset-peregrine @ 1.2.2
@magento/eslint-config @ 1.5.3
@magento/pagebuilder @ 7.4.2
@magento/peregrine @ 12.6.0
@magento/pwa-theme-venia @ 1.4.0
@magento/upward-security-headers @ 1.0.11
@magento/venia-ui @ 9.7.0
@magento/venia-sample-backends @ 0.0.9

ℹ Inspecting Magento Backend

venia-sample-backends is a "development-only" extension, please remove it from your project's package.json before going to production.

Using sample backend: https://venia-develop-ccewfjy-mfwmkrjfqvbjk.us-4.magentosite.cloud/
Backend is UP!

ℹ Inspecting System
OS: Darwin Kernel Version 22.1.0: Sun Oct 9 20:15:09 PDT 2022; root:xnu-8792.41.9~2/RELEASE_ARM64_T6000
Node Version: v18.12.1
NPM Version: 8.19.2

✨ Done in 4.35s.
}}`{{

Please complete the following device information:

Device: Mac
Browser: N/A - Terminal
Browser Version: N/A
Magento Version: Adobe Commerce 2.4
Please let us know what packages this bug is in regards to:

[ ] }}venia-concept{{
[ ] }}venia-ui{{
[x] }}pwa-buildpack{{
[ ] }}peregrine{{
[ ] }}pwa-devdocs{{
[ ] }}upward-js{{
[ ] }}upward-spec{{
[ ] }}create-pwa`

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sorry, something went wrong.

Copy link
Contributor

@bdenham bdenham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@bdenham bdenham enabled auto-merge (squash) March 27, 2023 15:05
@bdenham bdenham disabled auto-merge March 27, 2023 17:20
@bdenham bdenham self-assigned this Mar 27, 2023
@bdenham bdenham added the bug Something isn't working label Mar 27, 2023
@bdenham bdenham assigned bdenham and glo82145 and unassigned bdenham Mar 27, 2023
@bdenham bdenham self-requested a review March 27, 2023 20:35

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@bdenham bdenham enabled auto-merge (squash) March 28, 2023 05:39
@bdenham bdenham merged commit ccc00a1 into AdobeDocs:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working technical
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants