Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "COMDOX-840: Redesign Feedback component" #349

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

jeff-matthews
Copy link
Contributor

@jeff-matthews jeff-matthews commented Aug 13, 2024

Reverts #269 so that we can bump the theme and use the native sticky feedback component (#348).

@jeff-matthews jeff-matthews self-assigned this Aug 13, 2024
@jeff-matthews jeff-matthews added internal Differentiates work between community and Adobe staff maintenance labels Aug 13, 2024
@jeff-matthews jeff-matthews marked this pull request as ready for review August 13, 2024 19:49
@jeff-matthews
Copy link
Contributor Author

@dshevtsov, let me know if you want me to also bump the theme in this PR to save time.

@dshevtsov
Copy link
Contributor

@jeff-matthews let's keep it split for consistency and transparency.

@jeff-matthews jeff-matthews merged commit 33e03d6 into main Aug 13, 2024
18 checks passed
@jeff-matthews jeff-matthews deleted the revert-269-COMDOX-840-feedback-component branch August 13, 2024 20:05
@jeff-matthews
Copy link
Contributor Author

The production deployment failed, but I think that's because I was supposed to update dependencies after removing the shadowed files. The PR to bump the theme should fix it.

@dshevtsov
Copy link
Contributor

The production deployment failed, but I think that's because I was supposed to update dependencies after removing the shadowed files.

Then it should've failed during testing.

@dshevtsov
Copy link
Contributor

It can be a cache issue. I deleted all caches on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Differentiates work between community and Adobe staff maintenance
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants