Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unknown properties when deserializing response bodies #8

Merged
merged 2 commits into from
Jun 20, 2020
Merged

Ignore unknown properties when deserializing response bodies #8

merged 2 commits into from
Jun 20, 2020

Conversation

joschi
Copy link
Contributor

@joschi joschi commented Jun 20, 2020

In order to avoid breaking the client when a new property was added to the responses of the AdoptOpenJDK API, this PR disables the behavior of Jackson to fail on unknown properties.

https://github.com/FasterXML/jackson-docs/wiki/JacksonHowToIgnoreUnknown

Refs #6

@io7m
Copy link
Collaborator

io7m commented Jun 20, 2020

You beat me to it 👍

@io7m
Copy link
Collaborator

io7m commented Jun 20, 2020

Could you add yourself to the contributor list in the pom.xml file as was done in #7?

@io7m
Copy link
Collaborator

io7m commented Jun 20, 2020

Thank you! Very much appreciated.

@io7m io7m merged commit 4039ee8 into AdoptOpenJDK:develop Jun 20, 2020
io7m added a commit that referenced this pull request Jun 20, 2020
Release: openjdk-api-java-client 0.4.0
Change: Enable support for ignoring unrecognized fields. Thanks @joschi. (Ticket: #8)
Change: Add support for new fields. Thanks @maxandersen. (Ticket: #6)
io7m added a commit that referenced this pull request Jun 20, 2020
Release: openjdk-api-java-client 0.4.0

Change: Enable support for ignoring unrecognized fields. Thanks @joschi. (Ticket: #8)
Change: Add support for new fields. Thanks @maxandersen. (Ticket: #6)
@joschi joschi deleted the ignore-unknown-properties branch June 21, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants