Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag concatenating issue #512

Closed

Conversation

bharathappali
Copy link
Collaborator

The adopt image tag is been extracted here which expects only one tag in the format -t repo:tag but the sequence of tags are passed earlier so its resulting in a big concatenated string where -t are removed. So removing the loop as only one tag is getting passed to build_image here

Fixes #511

@dinogun @karianna Can i please have your views on this ?

@dinogun
Copy link
Collaborator

dinogun commented Feb 17, 2021

@bharathappali As mentioned, can you please add local for the local variables in all the functions of build_latest.sh. I think the issues are mainly because tags is getting reused in multiple places and causing this issue.

@bharathappali
Copy link
Collaborator Author

@dinogun I have given try in making functions use local vars but as its at multiple place I'm getting it messed up with my changes locally. As it is taking me a bit of time, the current fix solves the problem for stopping the docker images getting images updated daily. I would like to suggest a review of this PR and when its merged to look at the build jobs log to figure out at which point multiple tags are getting passed to build_image

Will be raising a new PR for the correction of local and global vars.

NOTE: Having a personal build feature at https://ci.adoptopenjdk.net/ for the changes to personal forks of openjdk-docker can be helpful in scenarios like this to test and make changes incrementally to the PR's

Please correct me if I'm wrong.

@karianna
Copy link
Member

@bharathappali - Can you rebase this and we'll take another look.

Signed-off-by: bharathappali <bharath.appali@gmail.com>
Signed-off-by: bharathappali <bharath.appali@gmail.com>
@bharathappali
Copy link
Collaborator Author

@karianna I have made changes to remove the loop as the loop iterating the tags is not required (multiple tags are not been passed - https://ci.adoptopenjdk.net/view/Docker%20Images/job/openjdk_build_docker_multiarch/266/consoleText all the entries are having only Tag - 0 as only one tag is passed)

Rebased to the current level. It's ready for review.

@dinogun
Copy link
Collaborator

dinogun commented Mar 29, 2021

This PR is not needed anymore as the changes in the Alpine PR make it redundant.

@bharathappali
Copy link
Collaborator Author

@dinogun can I please have a pointer to the Alpine PR ?

@bharathappali
Copy link
Collaborator Author

Closing this as #535 fixes it

@karianna karianna modified the milestones: March 2021, April 2021 Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tag issue with the build_latest.sh
3 participants