Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from nvaccess:master #93

Merged
merged 22 commits into from
Sep 2, 2024
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Aug 31, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

CyrilleB79 and others added 13 commits August 29, 2024 17:19
Closes #17063

Summary of the issue:
NVDA's User Guide specifies a too low amount of minimal disk space for NVDA.

Description of user facing changes
In the User Guide, update minimum required disk space to 200 MB.

While at it, updated the wording for lines above.

Description of development approach
I have chosen the next round value above. But we may use a higher value if needed. E.g.:

250 MB for a higher round value giving more room to future inclusions
300 MB, using a strategy according to which we would double the required value when the previously required value is exceeded.
…d overall improvement of TextInfo implementation (#17015)

Fixes #17006
Fixes #9941

Summary of the issue:
Wide character reporting in PowerPoint was broken.

Description of user facing changes
NVDA no longer fails reporting the caret position when a text frame contains wide characters.
NVDA is now able to report the position of characters.
Sentence navigation now works
Description of development approach
The TextInfo implementation for PowerPoint turns out to be pretty incomplete. I added offset calculations for characters, words and paragraphs.
There have been many updates to Comtypes since last time we updated.

Description of user facing changes
None

Description of development approach
Updated comtypes to 1.4.6.
Updated the UIAutomation comtypes wrapper.
…very row in the braille window, not just at the end (#17011)

Summary of the issue:
Although displaying a long line of braille on a multiline braille display fills up as much of the display as possible, rows may end in the middle of a word.
NVDA should honor the 'avoid splitting words when possible' Braille setting for all rows on the display.

Description of user facing changes
When displaying braille on a multiline braille display, NVDA will avoid splitting words over lines if the 'avoid splitting words when possible' braille setting is on.

Description of development approach
Rather than tracking a braille window as only _windowStartPos and _windowEndPos, internally store a list of window rows which map to start and end offsets in the braille buffer. These offsets are calculated each time the window is moved or the buffer is updated, and ensure that words are not split across window rows.

This PR also adds / changes the filters available for external code such as Remote to dictate the size of the display:

braille: Added a filter_displayDimensions extension point which takes a namedtuple of numRows and numCols, allowing external code to dictate the number of rows and columns for the display. This should be used now in place of filter_displaySize. This stops the worry of external code changing the number of rows but forgetting to change the over all size.
braille.handler: Added a displayDimensions property which:
creates a DisplayDimensions namedtuple of the display's real numRows and numCols.
Filters this with filter_displayDimensions.
Calculates displaySize from the product of the filtered numRows and numCols.
If at least one handler is registered on the old displaySize filter:
Filters this with the old filter_displaySize.
If the displaySize changes due to filtering, for backwards compatibility the DisplayDimensions numRows is set to 1 and numCols is set to the filtered displaySize.
If the DisplayDimensions have changed at all from the internal cache after all the filters and calculations, then fire the handle_displaySizechanged extension point passing displaySize, numRows and numCols.
This all means that new NVDA / remote code could specify full display dimensions, but for backwards compatibility, if the old displaySize filter is used, then braille is forced to a single row with displaySize cells.
From translation svn revision: 83225

Authors:
Juan C. buno <oprisniki@gmail.com>
Noelia Martinez <nrm1977@gmail.com>
Remy Ruiz <remyruiz@gmail.com>
Jose M. Delicado <jm.delicado@nvda.es>

Stats:
49	49	user_docs/es/changes.md
 1 file changed, 49 insertions(+), 49 deletions(-)
From translation svn revision: 83225

Authors:
Juan C. buno <oprisniki@gmail.com>
Ivan Novegil <ivan.novegil@nvda.es>
Javier Curras <javier.curras@nvda.es>
Jose M. Delicado <jm.delicado@nvda.es>

Stats:
29	29	user_docs/gl/changes.md
23	25	user_docs/gl/userGuide.md
 2 files changed, 52 insertions(+), 54 deletions(-)
From translation svn revision: 83225

Authors:
Cagri Dogan <cagrid@hotmail.com>

Stats:
36	29	user_docs/tr/changes.md
 1 file changed, 36 insertions(+), 29 deletions(-)
From translation svn revision: 83225
Revert "Fix reading the last empty line of a text in apps using Java Access Bridge"
@pull pull bot added the ⤵️ pull label Aug 31, 2024
LeonarddeR and others added 9 commits September 2, 2024 11:05
Related to vslavik/poedit#850

Summary of the issue:
The Poedit appmodule relies on some complex calculation logic to announce several pieces of information with shortcuts, e.g. translator notes/comments/warnings.
From translation svn revision: 83274

Authors:
Juan C. buno <oprisniki@gmail.com>
Ivan Novegil <ivan.novegil@nvda.es>
Javier Curras <javier.curras@nvda.es>
Jose M. Delicado <jm.delicado@nvda.es>

Stats:
53	53	user_docs/gl/changes.md
79	73	user_docs/gl/userGuide.md
 2 files changed, 132 insertions(+), 126 deletions(-)
From translation svn revision: 83274

Authors:
Diogo Costa <diogojoca@gmail.com>
Rui Batista <ruiandrebatista@gmail.com>
Rui Fontes <rui.fontes@tiflotecnia.com>
Ângelo Abrantes <ampa4374@gmail.com>

Stats:
1	1	user_docs/pt_PT/userGuide.md
 1 file changed, 1 insertion(+), 1 deletion(-)
From translation svn revision: 83274
…om UIA notification event (#10990)

Fixes #10950

Summary of the issue:
In recent Word 365 releases, NVDA will announce font attribute toggle message up to two times - a message defined by NVDA ,and a second time thanks to UIA notification event.

Description of how this pull request fixes the issue:
Builds on an earlier work on Word 365 UIA notification event suppression (#10851):

Adds a dedicated list in UIA.WordDocument class listing activity ID's NVDA should ignore.
Adds AccSN1, the activity Id for font attribute toggle messages.
Update translations from l10n
@pull pull bot merged commit 3f1a723 into Adriani90:master Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants