extension/src/lambda.js - handle nulls correctly #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jamiegardiner Thanks for your first contribution 🎉 |
butenkor
reviewed
Jun 2, 2020
butenkor
approved these changes
Jun 3, 2020
| errors: paymentResult.data.errors, | ||
| actions: paymentResult.data.actions | ||
| errors: paymentResult.data ? paymentResult.data.errors : undefined, | ||
| actions: paymentResult.data ? paymentResult.data.actions : undefined |
There was a problem hiding this comment.
Could you please add a comment to the code from your PR description as it is not obvious to the reader:
Null check around paymentResult.data, which can be null if paymentHandler short circuits when not an adyen payment
|
My mistake 🤦 I thought @butenkor already approved it, so I merged it, I will add the comment to the code. I will do the release today. |
|
@jamiegardiner https://github.com/commercetools/commercetools-adyen-integration/releases/tag/v4.0.1 the fix is released, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Null check around
paymentResult.data, which can be null ifpaymentHandlershort circuits when not an adyen payment