Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lambda support for notification module #69

Merged
merged 7 commits into from
Jun 26, 2019
Merged

Lambda support for notification module #69

merged 7 commits into from
Jun 26, 2019

Conversation

zackpollard
Copy link
Contributor

This PR provides the code necessary to run the notification module as a lambda. In order for adyen to call the lambda, you are required to spin up an API Gateway which invokes the lambda with the request from adyen.

@zackpollard zackpollard changed the title Lambdarise notification module Lambda support for notification module Jun 19, 2019
@zackpollard
Copy link
Contributor Author

This is the second part of the lambdarising work that we have been doing. Once this and #68 are merged, this will resolve #65. Please suggest any changes that you would like to see made to this PR.

Cheers!

lojzatran
lojzatran suggested changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@lojzatran lojzatran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Can you apply also the changes from the extension PR to this PR if it's valid?

@zackpollard zackpollard mentioned this pull request Jun 24, 2019
Merged
butenkor
butenkor approved these changes Jun 25, 2019
View reviewed changes
Copy link
Contributor

@butenkor butenkor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lojzatran lojzatran merged commit d17b78e into Adyen:master Jun 26, 2019
@zackpollard zackpollard deleted the feature/lambdarise-notification-module branch June 26, 2019 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lojzatran lojzatran lojzatran approved these changes

@butenkor butenkor butenkor approved these changes

@LEQADA LEQADA LEQADA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zackpollard @lojzatran @butenkor @LEQADA