Remove obsolete data from interface interactions #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ceIntegration.fields.notification
ahmetoz
changed the title
lojzatran
approved these changes
Nov 21, 2019
LEQADA
reviewed
Nov 21, 2019
butenkor
suggested changes
Nov 25, 2019
| @@ -52,7 +52,7 @@ describe('Cancel or refund', () => { | |||
|
|
|||
| const interfaceInteractionFields = updatedPayment.interfaceInteractions[1].fields | |||
| const adyenRequest = JSON.parse(interfaceInteractionFields.request) | |||
There was a problem hiding this comment.
Suggested change
| const adyenRequest = JSON.parse(interfaceInteractionFields.request) | |
| const adyenRequestBody = JSON.parse(interfaceInteractionFields.request) |
extension/test/integration/fetch-payment-method.handler.spec.js
Outdated
Show resolved
Hide resolved
extension/test/integration/credit-card-make-payment.handler.spec.js
Outdated
Show resolved
Hide resolved
extension/test/integration/credit-card-make-payment.handler.spec.js
Outdated
Show resolved
Hide resolved
butenkor
reviewed
Nov 25, 2019
| @@ -97,6 +97,9 @@ function calculateUpdateActionsForPayment (payment, notification) { | |||
| } | |||
|
|
|||
| function getAddInterfaceInteractionUpdateAction (notification) { | |||
| delete notification.additionalData | |||
There was a problem hiding this comment.
// strip away sensitive data
butenkor
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #63
Extensions:
Notification:
additionalDataandreasonfrom notification requests/responses: 0dff86bNote: cypress was not working in Travis for this I needed to update travis.yml: 95cd24c
Details: cypress-io/cypress#4069