#64 move 'charge' transactions to 'authorization' transactions according to the adyen best practices. #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahalberkamp
reviewed
Dec 2, 2019
Co-Authored-By: andreas Halberkamp <andreas.halberkamp@commercetools.de>
Co-Authored-By: andreas Halberkamp <andreas.halberkamp@commercetools.de>
ahmetoz
changed the title
ahalberkamp
approved these changes
Dec 4, 2019
ahmetoz
changed the title
butenkor
reviewed
Dec 4, 2019
Co-Authored-By: Roman Butenko <roman.butenko@commercetools.de>
Co-Authored-By: Roman Butenko <roman.butenko@commercetools.de>
Co-Authored-By: Roman Butenko <roman.butenko@commercetools.de>
LEQADA
reviewed
Dec 6, 2019
extension/package.json
Outdated
Comment on lines
7
to
9
| "test": "npm run unit && npm run integration", | ||
| "unit": "nyc mocha --exit --timeout 30000 --full-trace test/unit/**/*.spec.js", | ||
| "integration": "mocha --exit --timeout 30000 --full-trace test/integration/**/*.spec.js", |
There was a problem hiding this comment.
Wouldn't it be confusing to print test coverage only based on unit tests?
Comment on lines
+6
to
+8
| "test": "npm run unit && npm run integration", | ||
| "unit": "nyc mocha --check-leaks --timeout 30000 --full-trace --recursive \"./test/unit/**/*.spec.js\"", | ||
| "integration": "nyc mocha --check-leaks --timeout 30000 --full-trace --recursive \"./test/integration/**/*.spec.js\"", |
There was a problem hiding this comment.
npm run test will print code coverage twice. I think it's better if the implementation of the test script remains the same as before.
| const { body: { results: [ paymentBefore ] } } = await ctpClient.fetch(ctpClient.builder.payments) | ||
| expect(paymentBefore.transactions).to.have.lengthOf(1) | ||
| expect(paymentBefore.transactions[0].type).to.equal('Authorization') | ||
| expect(paymentBefore.transactions[0].state).to.equal('Initial') |
There was a problem hiding this comment.
So there will be no transaction in Initial state?
There was a problem hiding this comment.
according to our documentation, it's better to use pending in this test, it's pending state because the payment will go first to the extension module, so notification could trigger after some operations which are done by extension module, right?
Co-Authored-By: Roman Butenko <roman.butenko@commercetools.de>
Co-Authored-By: Hasan <LEQADA@users.noreply.github.com>
butenkor
approved these changes
Dec 10, 2019
| If the transaction is already charged, Adyen will do refund. | ||
| 1. In `Payment.transactions`, extension module finds the first transaction with `type='Charge' and state='Success'`. | ||
|
|
||
| - Both transaction types work the same, because Adyen will always pick the right action for the current transaction. |
There was a problem hiding this comment.
Suggested change
| - Both transaction types work the same, because Adyen will always pick the right action for the current transaction. | |
| - Both charge and refund is processed by Adyen in a similar manner and it will automatically pick the right action for the current transaction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#64
Todos: