COIOS-802: Identify native redirect flow (v5) #1879
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…native_redirect_flow' into COIOS-802_identify_native_redirect_flow
|
nauaros
dismissed stale reviews from goergisn and github-actions[bot]
via
7f206e2
|
| ❇️ | 1 Addition |
| 🔀 | 1 Modification |
AdyenActions
RedirectAction
❇️ Added
public enum RedirectType: Swift.Decodable, Swift.Equatable, Swift.Hashable, Swift.RawRepresentable, Swift.String {
case nativeRedirect
case redirect
public init(from decoder: any Swift.Decoder) throws
public init?(rawValue: Swift.String)
public typealias RawValue = Swift.String
public var rawValue: Swift.String { get }
}🔀 Modified
// From
public init(
url: Foundation.URL,
paymentData: Swift.String?,
nativeRedirectData: Swift.String? = nil,
paymentMethodType: Swift.String? = nil
)
// To
public init(
url: Foundation.URL,
paymentData: Swift.String?,
type: AdyenActions.RedirectAction.RedirectType = .redirect,
nativeRedirectData: Swift.String? = nil,
paymentMethodType: Swift.String? = nil
)
/**
Changes:
- Added parameter `type: AdyenActions.RedirectAction.RedirectType = .redirect`
*/Analyzed targets: Adyen, AdyenActions, AdyenCard, AdyenCashAppPay, AdyenComponents, AdyenDelegatedAuthentication, AdyenEncryption, AdyenSession, AdyenSwiftUI, AdyenTwint, AdyenWeChatPay
goergisn
requested review from
erenbesel,
goergisn,
atmamont and
neelSharma12
| let container = try decoder.container(keyedBy: CodingKeys.self) | ||
| self.url = try container.decode(URL.self, forKey: .url) | ||
| self.paymentData = try container.decodeIfPresent(String.self, forKey: .paymentData) | ||
| self.type = try container.decode(RedirectType.self, forKey: .type) |
There was a problem hiding this comment.
are we sure the RedirectType will always be returned?
otherwise we could do:
| self.type = try container.decode(RedirectType.self, forKey: .type) | |
| self.type = (try? container.decode(RedirectType.self, forKey: .type)) ?? FALLBACK_VALUE |
There was a problem hiding this comment.
Is there any other way to check its optionality? https://docs.adyen.com/api-explorer/Checkout/71/post/payments#responses-200-action-CheckoutRedirectAction-type
|
| @@ -9,12 +9,27 @@ import Foundation | |||
| /// Describes an action in which the user is redirected to a URL. | |||
| public struct RedirectAction: Decodable { | |||
|
|
|||
| /// Defines the type of redirect flow utilized by the `RedirectAction` object. | |||
| public enum RedirectType: String, Decodable { | |||
| // swiftlint:disable redundant_string_enum_value | |||
There was a problem hiding this comment.
Why do we need to add the string values when they are matching?
There was a problem hiding this comment.
just a guess - to not break anything if someone decides to rename enum case in the future?
| url: URL(string: "https://google.com")!, | ||
| paymentData: nil, | ||
| type: .nativeRedirect, | ||
| nativeRedirectData: "test_nativeRedirectData" |
There was a problem hiding this comment.
Documentation says it's just a string with no further explanation. Is this an URL or anything else? Should we have tests for this string?
Summary
This development enables us to differentiate between regular and native redirects. To handle cases where native redirects fail (indicated by
nativeRedirectDatabeingnil), it's essential to track the originating flow type of each redirect.Motivation
Native redirect flows can occasionally fail if
nativeRedirectDataisnilwithin the action object. Currently, we handle this by discarding the native redirect (checking ifnativeRedirectDatais nil), and defaulting to a "direct issuer flow" using a/detailscall.To avoid the additional steps of the "direct issuer flow," we can address this issue on the backend. By identifying the native redirect flow, we can still retrieve the native redirect result directly.
Release notes
Ticket
COIOS-802